-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reapply lost patch to L1TCaloLayer1 unpacker #15360
Conversation
Fixes ECAL link error readout unpacking for links with 4 towers Was 86f3ebc, then reverted
A new Pull Request was created by @nsmith- (Nicholas Smith) for CMSSW_8_0_X. It involves the following packages: EventFilter/L1TXRawToDigi @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
@davidlange6 I guess what I meant is that other packages (unrelated to this change) were showing changes when I tried to PR this against 81X. So I cherry-picked this commit onto |
+1 Checked that it has no effects on the L1T emulator unit-tests results. |
please test |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
+1 |
This is used for DQM and affects hardware monitoring information only.
It looks like 81X is out of sync with 8_0_16, should I wait for it to be in sync to make 81X PR or just cherry-pick this onto an IB?