Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply lost patch to L1TCaloLayer1 unpacker #15360

Merged
merged 1 commit into from Sep 22, 2016

Conversation

nsmith-
Copy link
Contributor

@nsmith- nsmith- commented Aug 3, 2016

This is used for DQM and affects hardware monitoring information only.

It looks like 81X is out of sync with 8_0_16, should I wait for it to be in sync to make 81X PR or just cherry-pick this onto an IB?

Fixes ECAL link error readout unpacking for links with 4 towers
Was 86f3ebc, then reverted
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2016

A new Pull Request was created by @nsmith- (Nicholas Smith) for CMSSW_8_0_X.

It involves the following packages:

EventFilter/L1TXRawToDigi

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@davidlange6
Copy link
Contributor

@nsmith- lets solve the 81x issue first - @mulhearn @rekovic should help. (maybe both are away just now)

@nsmith-
Copy link
Contributor Author

nsmith- commented Aug 29, 2016

@davidlange6 I guess what I meant is that other packages (unrelated to this change) were showing changes when I tried to PR this against 81X. So I cherry-picked this commit onto 8_1_0_pre10 and made #15644

@rekovic
Copy link
Contributor

rekovic commented Sep 7, 2016

+1

Checked that it has no effects on the L1T emulator unit-tests results.

@rekovic
Copy link
Contributor

rekovic commented Sep 7, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2016

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 322f741 into cms-sw:CMSSW_8_0_X Sep 22, 2016
@nsmith- nsmith- deleted the fixLinkUnpacker branch April 10, 2018 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants