Puppi isolation photons miniAOD #15375

ishvetso · 2016-08-05T13:15:39Z

PUPPI isolation for slimmedPhotons. Isolation is computed by CITK module based on packedPFCanidates. PUPPI isolation is stored as userFloat "PUPPI_Isolation".

cmsbuild · 2016-08-05T13:16:04Z

A new Pull Request was created by @ishvetso (Ivan Shvetsov) for CMSSW_8_1_X.

It involves the following packages:

PhysicsTools/PatAlgos

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @gpetruc, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder, @JyothsnaKomaragiri this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

slava77 · 2016-08-05T13:19:00Z

@cmsbuild please test

cmsbuild · 2016-08-05T13:19:20Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14378/console

cmsbuild · 2016-08-05T14:32:34Z

-1

Tested at: 7d875ba

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15375/14378/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

When I ran the RelVals I found an error in the following worklfows:
1330.0 step3

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step3_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log

136.731 step3

runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT+HARVESTDR2/step3_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT+HARVESTDR2.log

10024.0 step3

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017.log

50202.0 step3

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step3_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

ishvetso · 2016-08-05T16:18:10Z

I see the error message and it doesn't find the value map that has to be
produced to get PUPPI isolation in the PATPhotonSlimmer

that means the module was probably not run

my understanding was that one need to keep the objet in the
PhysicsTools/PatAlgos/python/slimming/MicroEventContent_cff.py and it
would be added in Unscheduled mode

is this not the case?

Regards,

Ivan

05.08.16 16:32, cmsbuild пишет:

-1

Tested at: 7d875ba
7d875ba

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15375/14378/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

When I ran the RelVals I found an error in the following worklfows:
1330.0 step3

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step3_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log

136.731 step3
runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT+HARVESTDR2/step3_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT+HARVESTDR2.log

10024.0 step3
runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017.log

50202.0 step3
runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step3_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log

25202.0 step3
runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#15375 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFMRQoLPDLm4_fznSwuEyzOIdNE3TVDzks5qc0mGgaJpZM4Jdq4-.

Best regards,
Ivan Shvetsov.

ishvetso · 2016-08-05T20:57:42Z

should value maps for PUPPI photons isolation be added to prevalidationMiniAOD? Please clarify

slava77 · 2016-08-05T21:25:44Z

PhysicsTools/PatAlgos/plugins/PATPhotonSlimmer.cc

+    modifyPhoton_(iConfig.getParameter<bool>("modifyPhotons")),
+    PUPPIIsolation_charged_hadrons_(consumes<edm::ValueMap<float> >(iConfig.getParameter<edm::InputTag>("PUPPIIsolationChargedHadrons"))),
+    PUPPIIsolation_neutral_hadrons_(consumes<edm::ValueMap<float> >(iConfig.getParameter<edm::InputTag>("PUPPIIsolationNeutralHadrons"))),
+    PUPPIIsolation_photons_(consumes<edm::ValueMap<float> >(iConfig.getParameter<edm::InputTag>("PUPPIIsolationPhotons")))


CMS style is to start variable names from lower case.

cmsbuild · 2016-08-05T21:56:40Z

Pull request #15375 was updated. @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please check and sign again.

cmsbuild · 2016-08-05T21:57:39Z

Pull request #15375 was updated. @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please check and sign again.

cmsbuild · 2016-08-05T22:07:14Z

Pull request #15375 was updated. @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please check and sign again.

cmsbuild · 2016-08-05T23:24:38Z

Pull request #15375 was updated. @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please check and sign again.

slava77 · 2016-08-05T23:42:38Z

@ishvetso are you done with the changes now?

ishvetso · 2016-08-05T23:45:46Z

yes, I think what you requested is done

slava77 · 2016-08-05T23:46:35Z

@cmsbuild please test

cmsbuild · 2016-08-05T23:46:51Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14397/console

cmsbuild · 2016-08-06T01:52:33Z

+1
Tested at: 9b2503a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15375/14397/summary.html

cmsbuild · 2016-08-06T02:34:50Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15375/14397/summary.html

ishvetso · 2016-08-08T12:56:32Z

any further feedback?

slava77 · 2016-08-09T15:14:11Z

no feedback so far.
Probably later today.

slava77 · 2016-08-12T22:11:39Z

+1

for #15375 9b2503a

code changes are as described; affecting only miniAOD outputs (a new userFloat is saved in slimmedPhotons)
jenkins tests pass and comparisons with baseline show no difference
local tests on AODSIM as input (*) in 3200 events show that a new module now runs egmPhotonPUPPIIsolationForPhotons (which takes under 1ms per event) and that the size of the slimmedPhotons branch increases slightly (by 4 bytes per event, or 0.3% for this branch alone adding to 1.2 kB in the slimmedPhotons branch).

(*) /store/relval/CMSSW_8_1_0_pre9/RelValProdZEE_13_pmx25ns/AODSIM/PUpmx25ns_81X_mcRun2_asymptotic_v2-v1/10000/28ED6D8D-BD53-E611-B892-0025905AA9F0.root

ishvetso added 4 commits August 3, 2016 13:13

add egmPhotonIsolationAOD

2b99aa6

add function to add CITK module

6acdbca

PUPPI isolation from packedPFcandidates

c38abe9

renaming

7d875ba

cmsbuild added this to the Next CMSSW_8_1_X milestone Aug 5, 2016

cmsbuild added reconstruction-pending analysis-pending pending-signatures tests-pending orp-pending comparison-pending labels Aug 5, 2016

cmsbuild added tests-started and removed tests-pending labels Aug 5, 2016

cmsbuild added tests-rejected and removed tests-started labels Aug 5, 2016

slava77 reviewed Aug 5, 2016
View reviewed changes

Update PATPhotonSlimmer.cc

e855e22

cmsbuild added tests-pending and removed tests-rejected labels Aug 5, 2016

Update slimmedPhotons_cfi.py

e5e25da

Update egmIsolationsPUPPI_cfi.py

3f3162c

Update MicroEventContent_cff.py

9b2503a

cmsbuild added tests-started and removed tests-pending labels Aug 5, 2016

cmsbuild added tests-approved and removed tests-started labels Aug 6, 2016

cmsbuild added comparison-available and removed comparison-pending labels Aug 6, 2016

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Aug 12, 2016

davidlange6 merged commit 9de92a0 into cms-sw:CMSSW_8_1_X Aug 15, 2016

ishvetso mentioned this pull request Aug 25, 2016

Puppi isolation electrons miniaod #15528

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Puppi isolation photons miniAOD #15375

Puppi isolation photons miniAOD #15375

ishvetso commented Aug 5, 2016

cmsbuild commented Aug 5, 2016

slava77 commented Aug 5, 2016

cmsbuild commented Aug 5, 2016 •

edited

cmsbuild commented Aug 5, 2016

ishvetso commented Aug 5, 2016 •

edited

ishvetso commented Aug 5, 2016

slava77 Aug 5, 2016

ishvetso Aug 5, 2016

cmsbuild commented Aug 5, 2016

cmsbuild commented Aug 5, 2016

cmsbuild commented Aug 5, 2016

cmsbuild commented Aug 5, 2016

slava77 commented Aug 5, 2016

ishvetso commented Aug 5, 2016

slava77 commented Aug 5, 2016

cmsbuild commented Aug 5, 2016 •

edited

cmsbuild commented Aug 6, 2016

cmsbuild commented Aug 6, 2016

ishvetso commented Aug 8, 2016

slava77 commented Aug 9, 2016

slava77 commented Aug 12, 2016

Puppi isolation photons miniAOD #15375

Puppi isolation photons miniAOD #15375

Conversation

ishvetso commented Aug 5, 2016

cmsbuild commented Aug 5, 2016

slava77 commented Aug 5, 2016

cmsbuild commented Aug 5, 2016 • edited

cmsbuild commented Aug 5, 2016

ishvetso commented Aug 5, 2016 • edited

ishvetso commented Aug 5, 2016

slava77 Aug 5, 2016

Choose a reason for hiding this comment

ishvetso Aug 5, 2016

Choose a reason for hiding this comment

cmsbuild commented Aug 5, 2016

cmsbuild commented Aug 5, 2016

cmsbuild commented Aug 5, 2016

cmsbuild commented Aug 5, 2016

slava77 commented Aug 5, 2016

ishvetso commented Aug 5, 2016

slava77 commented Aug 5, 2016

cmsbuild commented Aug 5, 2016 • edited

cmsbuild commented Aug 6, 2016

cmsbuild commented Aug 6, 2016

ishvetso commented Aug 8, 2016

slava77 commented Aug 9, 2016

slava77 commented Aug 12, 2016

cmsbuild commented Aug 5, 2016 •

edited

ishvetso commented Aug 5, 2016 •

edited

cmsbuild commented Aug 5, 2016 •

edited