Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HCAL DQM Updates #15380

Merged
merged 3 commits into from Aug 23, 2016
Merged

Conversation

vkhristenko
Copy link
Contributor

These are HCAL DQM Updates requested by Hcal Phase1, Hcal Operations, Hcal DPG

this PR is a copy of #14743 +

  1. Laser Monitoring and proper treatment of Laser/Event Types with uMNio
  2. Make compliant with Phase 1 processing.
  • Doesn't crash
  • In general treatment of Detector/Electronics/TrigTower ids should not crash any of the offline applications, but however if such are found, the summary for the run will bad.
  • Other small requests to add certain histograms
  • Remove the RECO w/o time constraints for Online hcal2 Application * Note, this is for Online!!! *

VK

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2016

A new Pull Request was created by @vkhristenko (Viktor Khristenko) for CMSSW_8_1_X.

It involves the following packages:

DQM/HcalCommon
DQM/HcalTasks
DQM/Integration

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@threus, @batinkov this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@kpedro88
Copy link
Contributor

kpedro88 commented Aug 7, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14403/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2016

@deguio
Copy link
Contributor

deguio commented Aug 8, 2016

@dmitrijus
please bring this one to the ORPs attention. this is an updated version of #14743 and needed for both online (laser) and phase1

thanks,
F.

@dmitrijus
Copy link
Contributor

+1

@dmitrijus
Copy link
Contributor

@deguio I will.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@dmitrijus dmitrijus mentioned this pull request Aug 9, 2016
@dmitrijus
Copy link
Contributor

+1

@dmitrijus
Copy link
Contributor

80x: #15381

@cmsbuild
Copy link
Contributor

Pull request #15380 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again.

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 17, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14561/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@kpedro88
Copy link
Contributor

@davidlange6 can this be merged now?

@davidlange6
Copy link
Contributor

+1
@vkhristenko - adding these using namespaces in headers (but within the hcaldqm namespace) is nominally ok, but may cause issues later -

@cmsbuild cmsbuild merged commit 7a65767 into cms-sw:CMSSW_8_1_X Aug 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants