Fix HcalHitsV for FastSim #15403
Fix HcalHitsV for FastSim #15403
Conversation
|
A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_8_1_X. It involves the following packages: Validation/HcalHits @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
Hi @kpedro88 - cool. @dmitrijus - any complaints? |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
+1 |
The issue was a difference of capitalization for the "ModuleLabel" parameter between the python config and the C++ analyzer code. It was not immediately obvious because the parameter was specified as untracked with a default value provided.
Let this be a lesson to all: untracked parameters are not a valid substitute for a proper fillDescriptions.*
In addition to fixing the capitalization problem, I added fillDescriptions for this analyzer and also cleaned up the FastSim Era usage in the python area. Hopefully the validation team can add fillDescriptions for the other analyzers at some point.
*Unless for some reason the validation/DQM code needs to use untracked parameters, in which case I can revert that part of the change, but I doubt this is the case.