additional and modified plots for SiStrip and Tracking DQM, for 80x #15422
Conversation
|
A new Pull Request was created by @manoni for CMSSW_8_0_X. It involves the following packages: DQM/SiStripMonitorCluster @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
| Nbinsx = cms.int32(3565), | ||
| xmin = cms.double(0), | ||
| xmax = cms.double(3564), | ||
| Nbinsy = cms.int32(200), |
There was a problem hiding this comment.
How many of instances of these will appear?
3565x200 ~1 M bins is already fairly large by itself.
Will this run in PromptReco?
There was a problem hiding this comment.
Only two instances. We need to monitor single bunch crossings so the x
axis bins can not be modified. Maybe we can reduce the y bins to half
(i.e 100) but the current value is an optimal one used also in offline
analysis. Let us know if this is a big issue.
Il 11/08/2016 15.42, Slava Krutelyov ha scritto:
In DQM/SiStripMonitorCluster/python/SiStripMonitorCluster_cfi.py
#15422 (comment):@@ -249,6 +291,26 @@
xmin = cms.double(-0.5)
),
TProfNClusStrip = cms.PSet(Nbinsx = cms.int32(3565),xmin = cms.double(0),xmax = cms.double(3564),Nbinsy = cms.int32(200),ymin = cms.double(-0.5),ymax = cms.double(99999.5),globalswitchon = cms.bool(True)),
TProfNClusPixel = cms.PSet(Nbinsx = cms.int32(3565),xmin = cms.double(0),xmax = cms.double(3564),Nbinsy = cms.int32(200),How many of instances of these will appear?
3565x200 ~1 M bins is already fairly large by itself.
Will this run in PromptReco?—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/cms-sw/cmssw/pull/15422/files/f9809ee7d33e765b8a898f678ee5acefd40e3f44#r74423562,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKYUWkLC_hsapokMZvd2c51jQ1lUdcLLks5qeybHgaJpZM4Jh59Y.
There was a problem hiding this comment.
O(1) instances should be OK.
less bins would be nicer is possible.
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
|
Compared to 81x, this lacks this commit, da7dc21 |
|
no, this is ok. By mistake that file has been changed in 81X but not in Il 16/08/2016 16.40, Dmitrijus ha scritto:
|
|
Please, can someone merge this PR? |
|
@dmitrijus can you request this to be merged ? (maybe at the ORP tomorrow ..) ? |
|
+1 |
Addition of 7 plots in the SiStripMonitorCluster class:
1) DeltaBx: Delta Bunch Crossing
2) DeltaBxCycle: Delta Bunch Crossing Cycle
3) AbsoluteBx_CStripVsCpixe: absolute bunch crossing in events with both pixel end strip on
4) MainDiagonalPosition_vs_BX: TProfile of absolute BX vs main diagonal position (tan^{-1}(NPix/kNStrip)))
5) TH2MainDiagonalPosition_vs_BX: TH2F of absolute BX vs main diagonal position (tan^{-1}(NPix/kNStrip)))
6) NumberOfClustersInStrip_vs_BX: # of Clusters in Strip vs absolute BX
7) NumberOfClustersInPixel_vs_BX: # of Clusters in Pixel vs absolute BX