rhoCorr binned in eta 80X, apply rhoCorr for H/E #15439

afiqaize · 2016-08-12T00:20:47Z

[ 80X clone of the #15440 ]

Pull request modifying the Egamma HLT producers so that rho correction can be applied in finer bins than 1 each for barrel/endcap.

Includes also a fix for the H producer for H/E (the original code does not do rho correction on H even if doRhoCorrection = true).

Affected modules in the HLT menu need to be reparsed. JIRA for this: CMSHLT-984.

Best regards,
Afiq

cmsbuild · 2016-08-12T00:21:08Z

A new Pull Request was created by @afiqaize (Afiq Anuar) for CMSSW_8_0_X.

It involves the following packages:

RecoEgamma/EgammaHLTProducers

@Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks.
@HuguesBrun, @rafaellopesdesa, @Sam-Harper, @lgray, @battibass this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

Martin-Grunewald · 2016-08-22T12:02:32Z

please test

cmsbuild · 2016-08-22T12:02:47Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14632/console

Martin-Grunewald · 2016-08-22T12:07:08Z

Code the deletion of the deprecated parameters in src/HLTrigger/Configuration/python/customizeHLTforCMSSW.py (both 80 and 81)

cmsbuild · 2016-08-22T13:22:08Z

-1

Tested at: 725c69f

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15439/14632/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

RelVals:

When I ran the RelVals I found an error in the following worklfows:
136.731 step2

runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT+HARVESTDR2/step2_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT+HARVESTDR2.log

1306.0 step2

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step2_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

1330.0 step2

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step2_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log

25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

AddOn:

I found errors in the following addon tests:

cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_0_X_2016-08-22-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Mon Aug 22 14:59:05 2016-date Mon Aug 22 14:55:36 2016 s - exit: 18688
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PRef_DATA.root --fileout file:RelVal_Raw_PRef_DATA_HLT_RECO.root : FAILED - time: date Mon Aug 22 14:59:05 2016-date Mon Aug 22 14:55:36 2016 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_0_X_2016-08-22-1100/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Mon Aug 22 14:59:44 2016-date Mon Aug 22 14:55:37 2016 s - exit: 18688
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --data --scenario=HeavyIons -n 10 --conditions auto:run2_data_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_HIon_DATA.root --fileout file:RelVal_Raw_HIon_DATA_HLT_RECO.root : FAILED - time: date Mon Aug 22 14:59:44 2016-date Mon Aug 22 14:55:37 2016 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_0_X_2016-08-22-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Mon Aug 22 15:11:52 2016-date Mon Aug 22 14:55:38 2016 s - exit: 18688
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun_MC.root --fileout file:RelVal_Raw_GRun_MC_HLT_RECO.root : FAILED - time: date Mon Aug 22 15:11:52 2016-date Mon Aug 22 14:55:38 2016 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_0_X_2016-08-22-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Mon Aug 22 15:11:28 2016-date Mon Aug 22 14:55:41 2016 s - exit: 18688
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PRef_MC.root --fileout file:RelVal_Raw_PRef_MC_HLT_RECO.root : FAILED - time: date Mon Aug 22 15:11:28 2016-date Mon Aug 22 14:55:41 2016 s - exit: 18688
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,HLT:@relval2016,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 --magField 38T_PostLS1 : FAILED - time: date Mon Aug 22 15:11:39 2016-date Mon Aug 22 14:55:45 2016 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_0_X_2016-08-22-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Mon Aug 22 15:03:22 2016-date Mon Aug 22 14:56:46 2016 s - exit: 18688
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PIon_DATA.root --fileout file:RelVal_Raw_PIon_DATA_HLT_RECO.root : FAILED - time: date Mon Aug 22 15:03:22 2016-date Mon Aug 22 14:56:46 2016 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_0_X_2016-08-22-1100/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Mon Aug 22 15:13:25 2016-date Mon Aug 22 14:59:53 2016 s - exit: 18688
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --mc --scenario=HeavyIons -n 10 --conditions auto:run2_mc_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_HIon_MC.root --fileout file:RelVal_Raw_HIon_MC_HLT_RECO.root : FAILED - time: date Mon Aug 22 15:13:25 2016-date Mon Aug 22 14:59:53 2016 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_0_X_2016-08-22-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Mon Aug 22 15:13:56 2016-date Mon Aug 22 15:09:30 2016 s - exit: 18688
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Mon Aug 22 15:13:56 2016-date Mon Aug 22 15:09:30 2016 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_0_X_2016-08-22-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Mon Aug 22 15:19:41 2016-date Mon Aug 22 15:11:48 2016 s - exit: 18688
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PIon_MC.root --fileout file:RelVal_Raw_PIon_MC_HLT_RECO.root : FAILED - time: date Mon Aug 22 15:19:41 2016-date Mon Aug 22 15:11:48 2016 s - exit: 18688

cmsbuild · 2016-08-22T20:58:02Z

Pull request #15439 was updated. @Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard, @davidlange6 can you please check and sign again.

fwyzard · 2016-08-23T00:20:38Z

@cmsbuild, please test

cmsbuild · 2016-08-23T00:53:37Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14652/console

cmsbuild · 2016-08-23T02:12:54Z

+1
Tested at: bdd51ff
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15439/14652/summary.html

cmsbuild · 2016-08-23T03:00:57Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15439/14652/summary.html

cmsbuild · 2016-08-23T13:18:20Z

Pull request #15439 was updated. @Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard, @davidlange6 can you please check and sign again.

Martin-Grunewald · 2016-08-23T13:27:33Z

please test

cmsbuild · 2016-08-23T13:28:29Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14672/console

fwyzard · 2016-08-23T13:29:57Z

+1

assuming successful Jenkins tests

cmsbuild · 2016-08-23T13:30:21Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

cmsbuild · 2016-08-23T14:47:09Z

+1
Tested at: 4e52b9a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15439/14672/summary.html

cmsbuild · 2016-08-23T15:31:41Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15439/14672/summary.html

davidlange6 · 2016-08-24T13:21:49Z

+1

cmsbuild added this to the Next CMSSW_8_0_X milestone Aug 12, 2016

cmsbuild added hlt-pending pending-signatures tests-pending orp-pending comparison-pending labels Aug 12, 2016

afiqaize mentioned this pull request Aug 12, 2016

rhoCorr binned in eta 81X, apply rhoCorr for H/E #15440

Merged

cmsbuild added tests-started and removed tests-pending labels Aug 22, 2016

cmsbuild added tests-rejected and removed tests-started labels Aug 22, 2016

Added the customizeHLTforCMSSW 80X

bdd51ff

afiqaize force-pushed the rhoCorr80X branch from 725c69f to bdd51ff Compare August 22, 2016 20:57

cmsbuild added tests-pending and removed tests-rejected labels Aug 22, 2016

cmsbuild added tests-started and removed tests-pending labels Aug 23, 2016

cmsbuild added tests-approved and removed tests-started labels Aug 23, 2016

cmsbuild removed the comparison-pending label Aug 23, 2016

use std::abs, cache the eta 80X

4e52b9a

cmsbuild added hlt-pending pending-signatures tests-pending comparison-pending and removed comparison-available fully-signed hlt-approved tests-approved labels Aug 23, 2016

cmsbuild added tests-started and removed tests-pending labels Aug 23, 2016

cmsbuild added hlt-approved fully-signed and removed hlt-pending pending-signatures labels Aug 23, 2016

cmsbuild added tests-approved and removed tests-started labels Aug 23, 2016

cmsbuild added comparison-available and removed comparison-pending labels Aug 23, 2016

cmsbuild added orp-approved and removed orp-pending labels Aug 24, 2016

cmsbuild merged commit e2ad251 into cms-sw:CMSSW_8_0_X Aug 24, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rhoCorr binned in eta 80X, apply rhoCorr for H/E #15439

rhoCorr binned in eta 80X, apply rhoCorr for H/E #15439

afiqaize commented Aug 12, 2016 •

edited

cmsbuild commented Aug 12, 2016

Martin-Grunewald commented Aug 22, 2016

cmsbuild commented Aug 22, 2016 •

edited

Martin-Grunewald commented Aug 22, 2016

cmsbuild commented Aug 22, 2016

cmsbuild commented Aug 22, 2016

fwyzard commented Aug 23, 2016 •

edited

cmsbuild commented Aug 23, 2016 •

edited

cmsbuild commented Aug 23, 2016

cmsbuild commented Aug 23, 2016

cmsbuild commented Aug 23, 2016

Martin-Grunewald commented Aug 23, 2016

cmsbuild commented Aug 23, 2016 •

edited

fwyzard commented Aug 23, 2016

cmsbuild commented Aug 23, 2016

cmsbuild commented Aug 23, 2016

cmsbuild commented Aug 23, 2016

davidlange6 commented Aug 24, 2016

rhoCorr binned in eta 80X, apply rhoCorr for H/E #15439

rhoCorr binned in eta 80X, apply rhoCorr for H/E #15439

Conversation

afiqaize commented Aug 12, 2016 • edited

cmsbuild commented Aug 12, 2016

Martin-Grunewald commented Aug 22, 2016

cmsbuild commented Aug 22, 2016 • edited

Martin-Grunewald commented Aug 22, 2016

cmsbuild commented Aug 22, 2016

cmsbuild commented Aug 22, 2016

fwyzard commented Aug 23, 2016 • edited

cmsbuild commented Aug 23, 2016 • edited

cmsbuild commented Aug 23, 2016

cmsbuild commented Aug 23, 2016

cmsbuild commented Aug 23, 2016

Martin-Grunewald commented Aug 23, 2016

cmsbuild commented Aug 23, 2016 • edited

fwyzard commented Aug 23, 2016

cmsbuild commented Aug 23, 2016

cmsbuild commented Aug 23, 2016

cmsbuild commented Aug 23, 2016

davidlange6 commented Aug 24, 2016

afiqaize commented Aug 12, 2016 •

edited

cmsbuild commented Aug 22, 2016 •

edited

fwyzard commented Aug 23, 2016 •

edited

cmsbuild commented Aug 23, 2016 •

edited

cmsbuild commented Aug 23, 2016 •

edited