Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standard tracking validation for phase2 #15448

Merged

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Aug 12, 2016

This PR switches phase2 validation to use the standard tracking validation instead of trackingOnly validation (the latter has significantly more histograms that are interesting for tuning tracking, but are not necessary for release validation).

Tested in CMSSW_8_1_X_2016-08-11-2300 (rebased on top of CMSSW_8_1_X_2016-08-18-1100), no changes expected for phase0/phase1. For phase2, the following folders in Tracking should disappear

  • TrackSeeding
  • TrackBuilding
  • From TrackAllTPEffic, everything else except general_... and cutsRecoHp_...
  • From TrackFromPV, everything else except general_..., cutsRecoHp_..., and simulation
  • From TrackFromPVAllTP, everything else except general_... and cutsRecoHp_...

and the following appear

  • TrackGsf
  • In TrackConversion, ckfInOutFromConversions_... and ckfOutInFromConversions_...
  • In Track, cutsRecoAK4PFJets

As a consequence, globalEfficiencies and ..._coll histograms under the folders above have changes too, and many ..._Mean and ..._Sigma histograms produced by DQMGenericClient may show tiny numerical differences.

@rovere @VinInn @ebrondol @kpedro88

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_1_X.

It involves the following packages:

Validation/Configuration

@civanch, @cvuosalo, @mdhildreth, @dmitrijus, @cmsbuild, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@kpedro88
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 12, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14500/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@civanch
Copy link
Contributor

civanch commented Aug 14, 2016

+1

@dmitrijus
Copy link
Contributor

+1

@cvuosalo
Copy link
Contributor

+1

For #15448 ffb73a1

Changing Phase 2 validation from trackingOnly to standard tracking.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-08-12-1100 show only the expected re-organization of DQM tracking plots in workflow 10424.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D1, along with minor numerical jitter.

@cmsbuild
Copy link
Contributor

Pull request #15448 was updated. @civanch, @cvuosalo, @mdhildreth, @dmitrijus, @cmsbuild, @slava77, @vanbesien, @davidlange6 can you please check and sign again.

@cvuosalo
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 18, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14591/console

@cmsbuild
Copy link
Contributor

@civanch
Copy link
Contributor

civanch commented Aug 19, 2016

+1

@cvuosalo
Copy link
Contributor

+1

For #15448 475a0dd

Second approval, after re-base. Jenkins tests are still OK and as expected.

@davidlange6 davidlange6 merged commit a9203ce into cms-sw:CMSSW_8_1_X Aug 22, 2016
@makortel makortel deleted the trkStandardValidationPhase2 branch February 12, 2018 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants