New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use standard tracking validation for phase2 #15448
Use standard tracking validation for phase2 #15448
Conversation
A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_1_X. It involves the following packages: Validation/Configuration @civanch, @cvuosalo, @mdhildreth, @dmitrijus, @cmsbuild, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 |
+1 |
+1 Changing Phase 2 validation from trackingOnly to standard tracking. The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-08-12-1100 show only the expected re-organization of DQM tracking plots in workflow 10424.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D1, along with minor numerical jitter. |
Pull request #15448 was updated. @civanch, @cvuosalo, @mdhildreth, @dmitrijus, @cmsbuild, @slava77, @vanbesien, @davidlange6 can you please check and sign again. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
+1 |
This PR switches phase2 validation to use the standard tracking validation instead of
trackingOnly
validation (the latter has significantly more histograms that are interesting for tuning tracking, but are not necessary for release validation).Tested in CMSSW_8_1_X_2016-08-11-2300 (rebased on top of CMSSW_8_1_X_2016-08-18-1100), no changes expected for phase0/phase1. For phase2, the following folders in
Tracking
should disappearTrackSeeding
TrackBuilding
TrackAllTPEffic
, everything else exceptgeneral_...
andcutsRecoHp_...
TrackFromPV
, everything else exceptgeneral_...
,cutsRecoHp_...
, andsimulation
TrackFromPVAllTP
, everything else exceptgeneral_...
andcutsRecoHp_...
and the following appear
TrackGsf
TrackConversion
,ckfInOutFromConversions_...
andckfOutInFromConversions_...
Track
,cutsRecoAK4PFJets
As a consequence,
globalEfficiencies
and..._coll
histograms under the folders above have changes too, and many..._Mean
and..._Sigma
histograms produced byDQMGenericClient
may show tiny numerical differences.@rovere @VinInn @ebrondol @kpedro88