Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

o2o ECAL(originally from depasse) #15491

Merged

Conversation

franzoni
Copy link

fw port of #15483:

. added handling of passwords via VarParsing
. connection string set to prod db; migration away from CondDBCommon_cfi

… VarParsing + migration away from CondDBCommon_cfi
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @franzoni (Giovanni Franzoni) for CMSSW_8_1_X.

It involves the following packages:

CondTools/Ecal

@ggovi, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@apfeiffer1, @argiro this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@franzoni
Copy link
Author

@cmsbuild
please test

@mmusich
Copy link
Contributor

mmusich commented Aug 17, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 17, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14564/console

@mmusich
Copy link
Contributor

mmusich commented Aug 17, 2016

@franzoni my understanding of the bot is that the test request needs to appear in the first line of the comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6 davidlange6 merged commit 8dbf867 into cms-sw:CMSSW_8_1_X Aug 18, 2016
@ggovi
Copy link
Contributor

ggovi commented Aug 19, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants