Update cache InputProductResolver only if this is the first thread #15505
Conversation
If multiple edm::Refs are requesting the same data product, they all get serialized by the DelayedReader. However, they would also all update the cached wrapper held by the InputProductResolver. This could cause some edm::Refs to get a pointer to a deleted data product. This fix now only updates the cache if it has not yet been set.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_1_X. It involves the following packages: FWCore/Framework @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
please test |
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
|
+1 |
If multiple edm::Refs are requesting the same data product, they all
get serialized by the DelayedReader. However, they would also all
update the cached wrapper held by the InputProductResolver. This
could cause some edm::Refs to get a pointer to a deleted data
product.
This fix now only updates the cache if it has not yet been set.