fixes needed for next root update

[smuzaffar]

Next root update which includes

cms-sw/root@ab679af

causes compilation errors due to ambiguous kUnset and ErrorHandler (defined in TError and xercesc).

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for CMSSW_8_1_X.

It involves the following packages:

Alignment/MuonAlignment
DataFormats/L1Trigger

@ghellwig, @cerminar, @cmsbuild, @rekovic, @franzoni, @mmusich, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @pakhotin, @abbiendi, @jhgoh, @tocheng, @mschrode, @trocino this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[smuzaffar]

please test with cms-sw/cmsdist#2450

[ghellwig]

@smuzaffar from inspecting the file and other parts of CMSSW I think the correct string would be XERCES_CPP_NAMESPACE instead of xercesc_3_1

[smuzaffar]

thanks, I will update it

[cmsbuild]

Pull request #15507 was updated. @ghellwig, @cerminar, @cmsbuild, @rekovic, @franzoni, @mmusich, @mulhearn, @davidlange6 can you please check and sign again.

[smuzaffar]

please test with cms-sw/cmsdist#2450

[cmsbuild]

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#2450
https://cmssdt.cern.ch/jenkins/job/cmsdist-cmssw-test-pr/71/console
https://cmssdt.cern.ch/jenkins/job/cmsdist-cmssw-test-pr/72/console

[ghellwig]

+1
provided jenkins agrees
trivial change for AlCa part

[cmsbuild]

-1

Tested at: f6a2fde

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
23e09da
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15507/72/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15507/72/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15507/72/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test DetectorDescriptionRegressionTestDOMCount had ERRORS
---> test test_DavixRead_http had ERRORS
---> test testORA_9 had ERRORS
---> test testNamedReference had ERRORS
---> test testContainerLock had ERRORS
---> test testNestedArrays had ERRORS
---> test testORA_0 had ERRORS
---> test testNameService had ERRORS
---> test testORA_4 had ERRORS
---> test testORABasicException had ERRORS
---> test testORA_1 had ERRORS
---> test testORA_7 had ERRORS
---> test testORA_5 had ERRORS
---> test testORA_6 had ERRORS
---> test testORA_11 had ERRORS
---> test testORA_10 had ERRORS
---> test testORAIO had ERRORS
---> test testORAInit had ERRORS
---> test testORAUtility had ERRORS
---> test testORA_3 had ERRORS
---> test testORA_12 had ERRORS
---> test testORA_2 had ERRORS
---> test testORA_8 had ERRORS

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
23e09da
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15507/72/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15507/72/git-merge-result

[smuzaffar]

these failures are not related to this PR. These unit tests are anyway failing in IBs

[smuzaffar]

@davidlange6 , if no objections then we should merge this along with the root update for 81X

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15507/72/summary.html