Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve initialization of EgHLTOfflineSource #15523

Merged
merged 3 commits into from Aug 20, 2016

Conversation

davidlange6
Copy link
Contributor

by reducing redundant calls to expensive code

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlange6 (David Lange) for CMSSW_8_1_X.

It involves the following packages:

DQMOffline/Trigger

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@rociovilar, @HuguesBrun, @trocino, @jhgoh, @battibass this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@davidlange6
Copy link
Contributor Author

please test

On Aug 19, 2016, at 11:27 AM, cmsbuild notifications@github.com wrote:

A new Pull Request was created by @davidlange6 (David Lange) for CMSSW_8_1_X.

It involves the following packages:

DQMOffline/Trigger

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@rociovilar, @HuguesBrun, @trocino, @jhgoh, @battibass this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 19, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14600/console

@cmsbuild
Copy link
Contributor

-1

Tested at: 2ffc7da

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15523/14600/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
1001.0 step1

DAS Error

@davidlange6
Copy link
Contributor Author

please test
(looks like a real das glitch)

On Aug 19, 2016, at 2:16 PM, cmsbuild notifications@github.com wrote:

-1

Tested at: 2ffc7da

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15523/14600/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:
When I ran the RelVals I found an error in the following worklfows:
1001.0 step1

DAS Error

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 19, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14602/console

@slava77
Copy link
Contributor

slava77 commented Aug 19, 2016

number 3 on my list in DQMEDAnalyzer::beginRun (this is 8-core case for "DQM:@standardDQM+@miniAODDQM" in run 274199 )
https://slava77sk.web.cern.ch/slava77sk/reco/cgi-bin/igprof-navigator/CMSSW_8_1_X_2016-08-18-1100-test-speedEGHLT-2ffc7da.274199.JetHT.step3.mt8.ne8.pp/33
This is almost x30 faster than the original version.

@dmitrijus
Copy link
Contributor

+1

thanks

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6 davidlange6 merged commit 39359b6 into cms-sw:CMSSW_8_1_X Aug 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants