Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

81x Fireworks: new version of ECAL detail view #15527

Merged
merged 31 commits into from Aug 24, 2016
Merged

81x Fireworks: new version of ECAL detail view #15527

merged 31 commits into from Aug 24, 2016

Conversation

alja
Copy link
Contributor

@alja alja commented Aug 19, 2016

This is a forward port of #15346

alja added 30 commits August 19, 2016 15:22
@alja
Search for detail views for complete list of plugins instad of availa…
8bf6f1f 
…ble plugins.
@alja
Allow more than 2 types of detail view.
3cb81b0
@alja
Changes in legend.
0ddd678
@alja
New ECAL rechit detail view.
332fad5
@alja
Separate filling for XY and EtaPhi histogram.
7741888
@alja
Add marker.
ac8caff
@alja
Handle numeric errors around -Pi , Pi.
60157f2
@alja
Remove debug print.
b4765bd
@alja
set orthographic camera by the default.
8284ebd
@alja
draw EB and EE.
3cda059
@alja
comment out marker
3330fba
@alja
Draw TEvBox for tower. Leave TEveCaloData empty.
b285669
@alja
add tooltip
ff0ca3f
@alja
remove oboslete code
e2d25d6
@alja
debug superclusters.
7e014be
@alja
remove EE specifics.
c107a97
@alja
remove EE specifics. comment out addTrackPointsinCaloData.
af4253b
@alja
set supercluster colors
94ae43f
@alja
Draw the tallest with a cross
a4ea594
@alja
Draw outline.
218c5ce
@alja
Draw 3DCaloLego in conversion detail view.
5d616c7
@alja
Remove color palette shortcut.
01a40ce
@alja
Make track line width configurable.
7478514
@alja
Make supercluster colors a tone darker.
5df6963
@alja
Put line and box in a compound.
cc0a277
@alja
Don't draw ecal barrel by the default.
452f87c
@alja
have consistent box and line color.
13df646
@alja
Search for reducedEGamma collection : miniaod case.
735b4c6
@alja
Remove debug print
6e7d260
@alja
Skip consumers (dependent module registration) for eacal rec hit base…
936f565 
…d detail views. In general need ecalRecHit_, reducedEcalRecHitsEB, or reducedEgamma. I presume the data will have one of those which is checked in FWECALDetailViewBuilder.
@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone Aug 19, 2016
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @alja (Alja Mrak-Tadel) for CMSSW_8_1_X.

It involves the following packages:

Fireworks/Calo
Fireworks/Candidates
Fireworks/Core
Fireworks/Electrons
Fireworks/Muons
Fireworks/Tracks

@cmsbuild, @alja, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@alja
Copy link
Contributor Author

alja commented Aug 22, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 22, 2016 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14640/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor

+1
Tested at: 936f565
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15527/14640/summary.html

@davidlange6
Copy link
Contributor

+1

@davidlange6 davidlange6 merged commit a92a5f2 into cms-sw:CMSSW_8_1_X Aug 24, 2016
@alja alja deleted the ECAL-DV-81-merge branch May 11, 2017 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-notrun fully-signed orp-approved tests-started visualization-approved
Projects
None yet
Milestone
Next CMSSW_8_1_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alja @cmsbuild @davidlange6