New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the radiation length and hadronic interaction length of unclassified materials #15550
Added the radiation length and hadronic interaction length of unclassified materials #15550
Conversation
A new Pull Request was created by @Michael-Krohn for CMSSW_8_1_X. It involves the following packages: Validation/Geometry @civanch, @Dr15Jones, @ianna, @mdhildreth, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
please test |
The tests are being triggered in jenkins. |
Brief description: this pull request is for changes to the classification of some materials in the tracker geometry description. These classifications did not involve any recalculation of material mixture properties; they were done by eye to materials whose classifications were already obvious: for example, materials in Phase I with exactly the same composition as their Phase 0 counterparts (for which the classifications have already been determined). |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
+1 |
|
||
Flange4_Airex 1.000 0.000 0.000 0.000 0.000 | ||
|
||
nge1_CFK 1.000 0.000 0.000 0.000 0.000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like there is a "Fla" missing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. Ping.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, you're correct. It appears I made a copy and paste error
No description provided.