Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the radiation length and hadronic interaction length of unclassified materials #15550

Merged
merged 1 commit into from Aug 30, 2016
Merged

Added the radiation length and hadronic interaction length of unclassified materials #15550

merged 1 commit into from Aug 30, 2016

Conversation

Michael-Krohn
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Michael-Krohn for CMSSW_8_1_X.

It involves the following packages:

Validation/Geometry

@civanch, @Dr15Jones, @ianna, @mdhildreth, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@Michael-Krohn Michael-Krohn reopened this Aug 23, 2016
@ianna
Copy link
Contributor

ianna commented Aug 23, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 23, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14682/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@friccita
Copy link
Contributor

Brief description: this pull request is for changes to the classification of some materials in the tracker geometry description. These classifications did not involve any recalculation of material mixture properties; they were done by eye to materials whose classifications were already obvious: for example, materials in Phase I with exactly the same composition as their Phase 0 counterparts (for which the classifications have already been determined).

@dmitrijus
Copy link
Contributor

+1

@ianna
Copy link
Contributor

ianna commented Aug 30, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d5eb24d into cms-sw:CMSSW_8_1_X Aug 30, 2016

Flange4_Airex 1.000 0.000 0.000 0.000 0.000

nge1_CFK 1.000 0.000 0.000 0.000 0.000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like there is a "Fla" missing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. Ping.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, you're correct. It appears I made a copy and paste error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants