Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Global Quality to show RED when FE is disabled #15552

Merged
merged 2 commits into from
Aug 24, 2016

Conversation

mbandrews
Copy link
Contributor

@mbandrews mbandrews commented Aug 22, 2016

Set Global and Raw Data Quality Summaries to correctly show RED when an FE is in DISABLED state:
(1) Include channels with integrity=kUnknown in global quality summary analysis.
(2) Set RawData Quality Summary to show RED when FE is in DISABLED state.

Background:
(1) At the moment, if integrity=kUnknown or kMUnknown, the channel is not analyzed.

  • The fix ensures status from other quality inputs are still propagated to Global Quality even if Integrity=kUnknown for that channel as occurs when there is low/zero digi occupancy
  • In collisions run 278821, the entire EE+04 was RED in Trigger Primitives but because Integrity showed YELLOW, the Bad status from TPs was not propagated to Global Quality. The nature of the problem caused digis to not be produced for this FED.
  • Moreover, a patch implemented by Pierre some time ago prevents DCC desync errors--which normally trigger the Integrity Summary to show RED--to no longer be propagated to the DQM, so DQM thinks there are no errors and that the occupancy is just harmlessly low/zero

(2) At the moment, an FE in DISABLED state is not a trigger for Raw Data Quality to show RED.

  • Also in collisions run 278821, the entire EE+04 was in RawData=DISABLED, with no raw data (and so digis and rechits) being produced for the entire FED. The whole run had to be flagged as BAD as a result.
  • As approved by PFG, the severity of the problem warrants RawData=DISABLED to be included in the list of states that should be set to show RED, as implemented in this fix

In conjunction with 81X PR #15553

@cmsbuild cmsbuild added this to the Next CMSSW_8_0_X milestone Aug 22, 2016
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mbandrews (Michael Andrews) for CMSSW_8_0_X.

It involves the following packages:

DQM/EcalMonitorClient

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@mbandrews mbandrews changed the title Include kUnknown integrity in Global Qt Set Global Quality to show RED when FE is disabled Aug 22, 2016
@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 23, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14659/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e65eaed into cms-sw:CMSSW_8_0_X Aug 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants