Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HCAL DPG HO filter modules #15558

Merged
merged 2 commits into from
Sep 7, 2016

Conversation

kfjack
Copy link
Contributor

@kfjack kfjack commented Aug 23, 2016

PR for the newly proposed HO filter skims from HCAL DPG (back port from PR #15557).

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kfjack (Kai-Feng Chen) for CMSSW_8_0_X.

It involves the following packages:

DPGAnalysis/Skims

@cmsbuild, @srimanob, @davidlange6, @hengne, @fabozzi can you please review it and eventually sign? Thanks.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@fabozzi
Copy link
Contributor

fabozzi commented Aug 30, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 30, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14831/console

@fabozzi
Copy link
Contributor

fabozzi commented Aug 31, 2016

@smuzaffar
can you please restart the test also here as in #15557 ?

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2016

Pull request #15558 was updated. @cmsbuild, @srimanob, @davidlange6, @hengne, @fabozzi can you please check and sign again.

@kfjack
Copy link
Contributor Author

kfjack commented Sep 3, 2016

Replaced with the standard deltaR & deltaPhi functions already. Please check. Many thanks.

@fabozzi
Copy link
Contributor

fabozzi commented Sep 3, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14924/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2016

@fabozzi
Copy link
Contributor

fabozzi commented Sep 4, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d4a8d62 into cms-sw:CMSSW_8_0_X Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants