Save pixel and strip layers in miniAOD #15605

gpetruc · 2016-08-25T11:55:07Z

Save also the strip and pixel layers for packed candidates.
For compactness, instead of saving then also the number of hits we save the number of extra hits (hits - layers).

Disk size cost seems to be ~100 bytes/event, on 8.5k TTbar (PUpmx25ns).

Validation module updated as well, and used to check that there is perfect agreement between the reported number of hits and layers in the strip and pixel detector between the AOD track, the PackedCandidate methods and the PackedCandidate pseudoTrack, on ~1k TTbar events, both for 2016 and 2017 scenarios.

When reading old MiniAODs, the number of layers will be reported as zero, and but the number of hits should still be correct (I didn't put any iorule magic to try to fudge a number of layers).

@arizzi @makortel @ferencek

… layers from HitPattern

…ew miniAOD, but will be zero when reading old ones, so better check both that and packedHits_ (which may be zero on new miniAODs if there's just one hit per layer)

cmsbuild · 2016-08-25T11:55:27Z

A new Pull Request was created by @gpetruc (Giovanni Petrucciani) for CMSSW_8_1_X.

It involves the following packages:

DQM/TrackingMonitor
DataFormats/PatCandidates

@cvuosalo, @dmitrijus, @cmsbuild, @montjj, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@hdelanno, @makortel, @fioriNTU, @cbernet, @idebruyn, @threus this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

arizzi · 2016-08-25T12:15:51Z

I guess we need an IORULE to correctly fill nHits when reading old files, isn't it?

gpetruc · 2016-08-25T12:23:57Z

As written in the PR description, no iorule should be needed to have the
right number of hits when reading the old miniAODs.

On Thu, Aug 25, 2016 at 2:15 PM, arizzi notifications@github.com wrote:

I guess we need an IORULE to correctly fill nHits when reading old files,
isn't it?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#15605 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEbbR0Q80W3ej9LAG13-6h00bDiVqHO6ks5qjYd7gaJpZM4Js_Ku
.

arizzi · 2016-08-25T12:30:57Z

ah right, apologies for reading the code only instead of the description :-)

On Thu, Aug 25, 2016 at 2:24 PM, Giovanni Petrucciani <
notifications@github.com> wrote:

As written in the PR description, no iorule should be needed to have the
right number of hits when reading the old miniAODs.

On Thu, Aug 25, 2016 at 2:15 PM, arizzi notifications@github.com wrote:

I guess we need an IORULE to correctly fill nHits when reading old files,
isn't it?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#15605 (comment), or
mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEbbR0Q80W3ej9LAG13-
6h00bDiVqHO6ks5qjYd7gaJpZM4Js_Ku>
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#15605 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEyilrXADCcm32GXzcnr0PqTdGy9kgKkks5qjYlggaJpZM4Js_Ku
.

makortel · 2016-08-25T12:34:58Z

Thanks for updating also the validation code.

slava77 · 2016-08-25T14:27:24Z

DataFormats/PatCandidates/interface/PackedCandidate.h

      if (numberOfPixelHits_ > trackPixelHitsMask) numberOfPixelHits_ = trackPixelHitsMask;
-      int numberOfStripHits_ = tk.hitPattern().numberOfValidHits() - numberOfPixelHits_;
+      int numberOfStripHits_ = tk.hitPattern().numberOfValidHits() - numberOfPixelHits_ - numberOfPixelLayers_ - numberOfStripLayers_;


some comments about the incremental meaning of values may be useful

slava77 · 2016-08-25T14:28:26Z

@cmsbuild please test

cmsbuild · 2016-08-25T14:28:45Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14732/console

gpetruc · 2016-08-25T14:34:47Z

ok, I can add some the comments after the tests are done

On Thu, Aug 25, 2016 at 4:28 PM, cmsbuild notifications@github.com wrote:

The tests are being triggered in jenkins.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#15605 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEbbR52Syp5R7oin0QPUlX8445315qedks5qjaaggaJpZM4Js_Ku
.

cmsbuild · 2016-08-25T16:45:24Z

+1
Tested at: 4d00309
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15605/14732/summary.html

cmsbuild · 2016-08-25T18:03:54Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15605/14732/summary.html

gpetruc · 2016-08-26T11:38:32Z

Added comments explaining the logic, as per Slava's comment.
The new commit 45fe985 only adds comments, so you don't need to rerun the tests

cmsbuild · 2016-08-26T11:40:19Z

Pull request #15605 was updated. @cvuosalo, @dmitrijus, @cmsbuild, @montjj, @slava77, @vanbesien, @davidlange6 can you please check and sign again.

slava77 · 2016-08-26T19:45:46Z

@gpetruc
are you planning a backport to 80X for the rereco?

slava77 · 2016-08-26T19:46:08Z

@cmsbuild please test
[even though it's cosmetic]

cmsbuild · 2016-08-26T19:46:25Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14764/console

cmsbuild · 2016-08-26T23:50:12Z

+1
Tested at: 45fe985
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15605/14764/summary.html

cmsbuild · 2016-08-27T00:34:25Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15605/14764/summary.html

cvuosalo · 2016-08-28T23:35:37Z

+1

For #15605 45fe985

Adding pixel and strip layers to packed candidates in Mini-AOD.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-08-26-1100 show no significant differences, as expected. The new DQM histograms do appear in the Jenkins output DQM files. An extended test of workflow 136.731_RunSinglePh2016B with 20 events against baseline CMSSW_8_1_0_pre10 shows no significant differences, and the additions to the packed candidates do show up in the Mini-AOD output:

   or, B         new, B      delta, B   delta, %   deltaJ, %    branch 
-----------------------------------------------------------------
  12621.6 ->     12753.5        132      1.0   0.09     patPackedCandidates_packedPFCandidates__reRECO.
   1348.5 ->      1398.5         50      3.6   0.03     patPackedCandidates_lostTracks__reRECO.
-------------------------------------------------------------
   145446 ->      145626        180             0.1     ALL BRANCHES

dmitrijus · 2016-08-29T12:01:56Z

+1

ferencek · 2016-08-30T09:42:49Z

This was already asked but I have not seen a clear reply. @gpetruc, will there be a 80X backport of this PR?

gpetruc · 2016-08-30T10:49:48Z

Yep, it's #15641

On Tue, Aug 30, 2016 at 11:42 AM, Dinko Ferencek notifications@github.com
wrote:

This was already asked but I have not seen a clear reply. @gpetruc
https://github.com/gpetruc, will there be a 80X backport of this PR?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#15605 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEbbR8PNvr-WbfthRRKn4tnovEdMu3RUks5qk_sbgaJpZM4Js_Ku
.

ferencek · 2016-08-30T11:23:05Z

Perfect, thanks. I was not getting GitHub emails about the backport PR
so wasn't sure if it existed but now I also see that the backport PR
references this PR so I would have answered my question if I looked more
carefully.

On 08/30/2016 12:49 PM, Giovanni Petrucciani wrote:

Yep, it's #15641

On Tue, Aug 30, 2016 at 11:42 AM, Dinko Ferencek notifications@github.com
wrote:

This was already asked but I have not seen a clear reply. @gpetruc
https://github.com/gpetruc, will there be a 80X backport of this PR?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#15605 (comment),
or mute
the thread

https://github.com/notifications/unsubscribe-auth/AEbbR8PNvr-WbfthRRKn4tnovEdMu3RUks5qk_sbgaJpZM4Js_Ku
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#15605 (comment), or
mute the thread
https://github.com/notifications/unsubscribe-auth/AEqLKVlHmUq_DUUVmzzvsiPvDt6qKuehks5qlArPgaJpZM4Js_Ku.

gpetruc added 5 commits August 25, 2016 10:22

Add strip and pixel layers to the miniAOD packed candidates

c2e9c66

Monitoring of layers in PackedCandidateTrackValidator

71d6347

PackedCandidateTrackValidator: Include monitoring plots of numbers of…

1a9b060

… layers from HitPattern

PackedCandidate::bestTrack with the right number of layers

09284c6

Fix check on bestTrack(). packedLayers_ is not going to be zero for n…

4d00309

…ew miniAOD, but will be zero when reading old ones, so better check both that and packedHits_ (which may be zero on new miniAODs if there's just one hit per layer)

cmsbuild added this to the Next CMSSW_8_1_X milestone Aug 25, 2016

cmsbuild added reconstruction-pending dqm-pending analysis-pending pending-signatures tests-pending orp-pending comparison-pending labels Aug 25, 2016

slava77 reviewed Aug 25, 2016
View reviewed changes

cmsbuild added tests-started and removed tests-pending labels Aug 25, 2016

cmsbuild added tests-approved and removed tests-started labels Aug 25, 2016

ferencek mentioned this pull request Aug 25, 2016

btag HIP mitigation + ctag bugfix #15421

Merged

cmsbuild added tests-pending comparison-pending and removed comparison-available tests-approved labels Aug 26, 2016

cmsbuild added tests-started and removed tests-pending labels Aug 26, 2016

cmsbuild added tests-approved and removed tests-started labels Aug 26, 2016

cmsbuild added comparison-available and removed comparison-pending labels Aug 27, 2016

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Aug 28, 2016

gpetruc mentioned this pull request Aug 29, 2016

Save pixel and strip layers in miniAOD (80X) #15641

Merged

cmsbuild added dqm-approved and removed dqm-pending labels Aug 29, 2016

davidlange6 merged commit 5d19ae7 into cms-sw:CMSSW_8_1_X Aug 29, 2016

ferencek mentioned this pull request Aug 31, 2016

Updated IVF trackMinLayers cut in jetTools.py for MiniAOD #15684

Merged

makortel mentioned this pull request Aug 8, 2017

Update tracking MC validation scripts #20081

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Save pixel and strip layers in miniAOD #15605

Save pixel and strip layers in miniAOD #15605

gpetruc commented Aug 25, 2016

cmsbuild commented Aug 25, 2016

arizzi commented Aug 25, 2016

gpetruc commented Aug 25, 2016

arizzi commented Aug 25, 2016

makortel commented Aug 25, 2016

slava77 Aug 25, 2016

slava77 commented Aug 25, 2016

cmsbuild commented Aug 25, 2016 •

edited

gpetruc commented Aug 25, 2016

cmsbuild commented Aug 25, 2016

cmsbuild commented Aug 25, 2016

gpetruc commented Aug 26, 2016

cmsbuild commented Aug 26, 2016

slava77 commented Aug 26, 2016

slava77 commented Aug 26, 2016

cmsbuild commented Aug 26, 2016 •

edited

cmsbuild commented Aug 26, 2016

cmsbuild commented Aug 27, 2016

cvuosalo commented Aug 28, 2016

dmitrijus commented Aug 29, 2016

ferencek commented Aug 30, 2016

gpetruc commented Aug 30, 2016

ferencek commented Aug 30, 2016

Save pixel and strip layers in miniAOD #15605

Save pixel and strip layers in miniAOD #15605

Conversation

gpetruc commented Aug 25, 2016

cmsbuild commented Aug 25, 2016

arizzi commented Aug 25, 2016

gpetruc commented Aug 25, 2016

arizzi commented Aug 25, 2016

makortel commented Aug 25, 2016

slava77 Aug 25, 2016

Choose a reason for hiding this comment

slava77 commented Aug 25, 2016

cmsbuild commented Aug 25, 2016 • edited

gpetruc commented Aug 25, 2016

cmsbuild commented Aug 25, 2016

cmsbuild commented Aug 25, 2016

gpetruc commented Aug 26, 2016

cmsbuild commented Aug 26, 2016

slava77 commented Aug 26, 2016

slava77 commented Aug 26, 2016

cmsbuild commented Aug 26, 2016 • edited

cmsbuild commented Aug 26, 2016

cmsbuild commented Aug 27, 2016

cvuosalo commented Aug 28, 2016

dmitrijus commented Aug 29, 2016

ferencek commented Aug 30, 2016

gpetruc commented Aug 30, 2016

ferencek commented Aug 30, 2016

cmsbuild commented Aug 25, 2016 •

edited

cmsbuild commented Aug 26, 2016 •

edited