Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep lumi from scalers #15622

Merged
merged 1 commit into from
Sep 7, 2016
Merged

Conversation

gpetruc
Copy link
Contributor

@gpetruc gpetruc commented Aug 26, 2016

80X backport of #15585, for a future re-reco or update of prompt reco or re-miniAOD.

@cmsbuild cmsbuild added this to the Next CMSSW_8_0_X milestone Aug 26, 2016
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gpetruc (Giovanni Petrucciani) for CMSSW_8_0_X.

It involves the following packages:

PhysicsTools/PatAlgos

@cmsbuild, @cvuosalo, @slava77, @montjj, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @JyothsnaKomaragiri, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented Aug 26, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 26, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14754/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

urgent

@cvuosalo
Copy link
Contributor

+1

For #15622 911f2a5

Add lumi scalers to Mini-AOD. There should be no change in monitored quantities.

#15585 is the 81X version of this PR, and it has already been merged.

The code change is satisfactory, and Jenkins tests against baseline CMSSW_8_0_X_2016-08-25-2300 show no significant differences, as expected. See #15585 for test details confirming the addition of the lumi scalers.

@slava77
Copy link
Contributor

slava77 commented Aug 30, 2016

hold

added a formal hold label to denote that this is to be merged only once the rereco release is to be built

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @slava77
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants