Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTPPS: empty alignment fix #15675

Merged
merged 2 commits into from Sep 5, 2016
Merged

Conversation

grzanka
Copy link
Contributor

@grzanka grzanka commented Aug 31, 2016

Fixes a bug which resulted in empty alignment being returned.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @grzanka (Leszek Grzanka) for CMSSW_8_1_X.

It involves the following packages:

Geometry/VeryForwardGeometryBuilder

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@grzanka
Copy link
Contributor Author

grzanka commented Aug 31, 2016

@slava77 could you please take a look ? Once it is merged I will backport it to 80X.

@slava77
Copy link
Contributor

slava77 commented Aug 31, 2016

@cmsbuild please test

@grzanka I'm not sure what I should be checking
cmsbuild tests should show if code runs OK (if it's supposed to be running in the 2016B workflow, where we are using a run with CTPPS included)

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 31, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14857/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@ianna
Copy link
Contributor

ianna commented Sep 5, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5794a31 into cms-sw:CMSSW_8_1_X Sep 5, 2016
cmsbuild added a commit that referenced this pull request Sep 8, 2016
CTPPS: empty alignment fix - backport of #15675
@jan-kaspar jan-kaspar deleted the CTPPS/alignment_bugfix branch December 4, 2020 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants