Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep muon parents (80X backport) #15742

Merged
merged 1 commit into from
Sep 7, 2016

Conversation

gpetruc
Copy link
Contributor

@gpetruc gpetruc commented Sep 6, 2016

Backport of #14384

Would be useful to have for the new MC production

@arizzi @kskovpen @ferencek

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2016

A new Pull Request was created by @gpetruc (Giovanni Petrucciani) for CMSSW_8_0_X.

It involves the following packages:

PhysicsTools/PatAlgos

@cmsbuild, @cvuosalo, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @JyothsnaKomaragiri, @gkasieczka, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@kskovpen
Copy link
Contributor

kskovpen commented Sep 6, 2016

Thanks a lot, Giovanni !

Le 6 sept. 2016 à 11:30, Giovanni Petrucciani notifications@github.com a écrit :

Backport of #14384 #14384
Would be useful to have for the new MC production

@arizzi https://github.com/arizzi @kskovpen https://github.com/kskovpen @ferencek https://github.com/ferencek
You can view, comment on, or merge this pull request online at:

#15742 #15742
Commit Summary

keep muon parents
File Changes

M PhysicsTools/PatAlgos/python/slimming/prunedGenParticles_cfi.py https://github.com/cms-sw/cmssw/pull/15742/files#diff-0 (1)
Patch Links:

https://github.com/cms-sw/cmssw/pull/15742.patch https://github.com/cms-sw/cmssw/pull/15742.patch
https://github.com/cms-sw/cmssw/pull/15742.diff https://github.com/cms-sw/cmssw/pull/15742.diff

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #15742, or mute the thread https://github.com/notifications/unsubscribe-auth/AFFMUiSP7PRy1tbROxcKdKwLGt_5b54Bks5qnTKvgaJpZM4J1o6l.

@slava77
Copy link
Contributor

slava77 commented Sep 6, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14966/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2016

@slava77
Copy link
Contributor

slava77 commented Sep 6, 2016

+1

for #15742 d1f82fd

  • changes are in line with the description. The same change as in 81X PR Keep muon parents in prunedGenParticles collection #14384 merged in May
  • jenkins tests pass and comparisons with baseline show no differences.
    • additional candidates are fairly rare in tested workflows and would not affect DQM plots. See 81X PR for expected changes in muon enriched samples

@davidlange6 davidlange6 merged commit 39858c9 into cms-sw:CMSSW_8_0_X Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants