Backport bug fix for dumpPython function with empty sequences

[wddgit]

No description provided.

[cmsbuild]

A new Pull Request was created by @wddgit (W. David Dagenhart) for CMSSW_8_0_X.

It involves the following packages:

FWCore/ParameterSet

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wmtan this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[slava77]

@cmsbuild please test

@wddgit how many packages did the checkdeps pull in?

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15056/console
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15057/console

[slava77]

ok, I see in jenkins console already that there are many packages on the dep list (most of what we have, apparently)

[wddgit]

I only tested with Core packages. I did not try checkups. All the changes are in python and none in the interface and it only effects dumpPython. Will running the RelVals even exercise this? It cannot cause build problems.

[wddgit]

OK I meant "I did not try checkdeps". GitHub thought it was a spelling error and changed it to checkups ...

[slava77]

On 9/8/16 4:03 PM, W. David Dagenhart wrote:

I only tested with Core packages. I did not try checkups. All the
changes are in python and none in the interface and it only effects
dumpPython. Will running the RelVals even exercise this? It cannot cause
build problems.

I wanted to test this on the data processing config.
I prefer consistent builds, which means checkdeps (it will take too long)
or an alternative to wait for an IB (it will take too long)
or an alternative to not do checkdeps (it's uncomfortable).
I guess I'll try with the latter.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#15791 (comment), or
mute the thread
https://github.com/notifications/unsubscribe-auth/AEdcbnezPwUETSl8u9zJ82L55yew77o8ks5qoJRbgaJpZM4J4h8_.

[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[cmsbuild]

-1

Tested at: 92805d8

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15791/15057/summary.html

I found follow errors while testing this PR

Failed tests: Build

• Build:

I found an error when building:

>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-09-08-2300/src/RecoCTPPS/TotemRPLocal/plugins/TotemRPRecHitProducer.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-09-08-2300/src/RecoCTPPS/TotemRPLocal/plugins/TotemRPLocalTrackFitter.cc 
In file included from /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_0_X_2016-09-08-2300/src/FastSimulation/CaloHitMakers/interface/EcalHitMaker.h:7:0,
                 from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-09-08-2300/src/FastSimulation/Calorimetry/interface/CalorimetryManager.h:13,
                 from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-09-08-2300/src/FastSimulation/Calorimetry/src/CalorimetryManager.cc:7:
/cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_0_X_2016-09-08-2300/src/FastSimulation/CaloHitMakers/interface/CaloHitMaker.h:27:23: error: 'Plane3D' in namespace 'ROOT::Math' does not name a type
   typedef ROOT::Math::Plane3D Plane3D;
                       ^
/cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_0_X_2016-09-08-2300/src/FastSimulation/CaloHitMakers/interface/CaloHitMaker.h:45:35: error: 'Plane3D' does not name a type
   static XYZPoint intersect(const Plane3D& p,const XYZPoint& a,const XYZPoint& b,double& t,bool segment,bool debug=false);
                                   ^


[slava77]

interesting
we didn't have a full build since CMSSW_8_0_19_patch1. I wonder if a failure here actually means a broken full build IB

[slava77]

@cmsbuild please test
.. maybe it works with another attempt

[slava77]

backport of #15790

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15063/console

[davidlange6]

this PR checks out on 650 packages...

[cmsbuild]

-1

Tested at: 92805d8

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15791/15063/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test runtestSimCalorimetryHGCalSimProducers had ERRORS
---> test runtestRecoLocalCaloHGCalRecProducers had ERRORS

[Dr15Jones]

The test failures are unrelated to this pull request. They are both complaining about bad indices used in the mixing module

%MSG-e SiStripLorentzAngle:  MixingModule:mix 09-Sep-2016 15:17:39 CEST  Run: 1 Event: 1
SiStripLorentzAngle for DetID 442032132 is not stored
%MSG
----- Begin Fatal Exception 09-Sep-2016 15:17:53 CEST-----------------------
An exception of category 'CorruptedData' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'digitisation_step'
   [2] Calling event method for module MixingModule/'mix'
Exception Message:
[SiStripThreshold::getData] asking for data for a strip 128 lower then the first stored strip 112
----- End Fatal Exception -------------------------------------------------

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15791/15063/summary.html