Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bsunanda:Phase2-hgx65 SS absorber option for HGCal FH/BH #15825

Merged
merged 3 commits into from Sep 16, 2016

Conversation

bsunanda
Copy link
Contributor

No description provided.

@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone Sep 13, 2016
@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 13, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15100/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for CMSSW_8_1_X.

It involves the following packages:

Configuration/Geometry
Geometry/CMSCommonData
Geometry/HGCalCommonData
Geometry/HcalCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@ianna
Copy link
Contributor

ianna commented Sep 13, 2016

@bsunanda - FYI, direct changes to 2023 scenarios are no longer allowed. Please, modify 2023 dictionary (*) and regenerate the scenarios. Thanks.

*) http://cmslxr.fnal.gov/source/Configuration/Geometry/scripts/dict2023Geometry.py?v=CMSSW_8_1_X_2016-09-12-2300

@ianna
Copy link
Contributor

ianna commented Sep 13, 2016

-1

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@davidlange6
Copy link
Contributor

please test

@bsunanda
Copy link
Contributor Author

@ianna Please check this now

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 13, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15113/console

@cmsbuild cmsbuild removed the hold label Sep 16, 2016
@cmsbuild
Copy link
Contributor

Pull request #15825 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please check and sign again.

@bsunanda
Copy link
Contributor Author

I discussed this with Chris. We shall keep the C2 option as it is. We shall have C3 option when we have the additional handle the gaps at inner and outer edge. So I have removed the configuration but kept the xml files which are to be retained

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 16, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15173/console

@cmsbuild
Copy link
Contributor

@ianna
Copy link
Contributor

ianna commented Sep 16, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit af763d9 into cms-sw:CMSSW_8_1_X Sep 16, 2016
@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants