Fixed MPS validation tool

[prigoll]

Fix of the mpsvalidation tool for the Millepede Alignment Fit #15642
Fixes:

• changed title of axis
• changed visibilty of outliers
• added units to warnings and axis
• fixed label size

80X backport of #15849

[cmsbuild]

A new Pull Request was created by @prigoll for CMSSW_8_0_X.

It involves the following packages:

Alignment/MillePedeAlignmentAlgorithm

@ghellwig, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@mschrode, @ghellwig, @mmusich, @tocheng, @tlampen this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[mmusich]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15135/console

[ghellwig]

+1
trivial changes

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[cmsbuild]

-1

Tested at: 1cf05b6

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15851/15135/summary.html

I found follow errors while testing this PR

Failed tests: Build

• Build:

I found an error when building:

>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-09-13-2300/src/Utilities/StaticAnalyzers/src/ConstCastChecker.cpp 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-09-13-2300/src/Utilities/StaticAnalyzers/src/ConstCastAwayChecker.cpp 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-09-13-2300/src/Utilities/StaticAnalyzers/src/edmChecker.cpp 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-09-13-2300/src/Utilities/StaticAnalyzers/src/MutableMemberChecker.cpp 
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-09-13-2300/src/Utilities/StaticAnalyzers/src/FiniteMathChecker.cc: In member function 'void clangcms::FiniteMathChecker::checkPreStmt(const clang::CallExpr_, clang::ento::CheckerContext&) const':
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-09-13-2300/src/Utilities/StaticAnalyzers/src/FiniteMathChecker.cc:33:51: error: no matching function for call to 'clang::ento::CheckerContext::generateSink()'
   clang::ento::ExplodedNode *N = ctx.generateSink();
                                                   ^
In file included from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-09-13-2300/src/Utilities/StaticAnalyzers/src/FiniteMathChecker.h:5:0,
                 from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_0_X_2016-09-13-2300/src/Utilities/StaticAnalyzers/src/FiniteMathChecker.cc:1:
/cvmfs/cms-ib.cern.ch/2016-38/slc6_amd64_gcc530/external/llvm/3.8.0-giojec/include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h:229:17: note: candidate: clang::ento::ExplodedNode_ clang::ento::CheckerContext::generateSink(clang::ento::ProgramStateRef, clang::ento::ExplodedNode_, const clang::ProgramPointTag_)


[ghellwig]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15151/console

[cmsbuild]

+1
Tested at: 1cf05b6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15851/15151/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15851/15151/summary.html

[davidlange6]

+1