New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pr81x l1t v86.2 tsg v9.2 rebased #15865
Pr81x l1t v86.2 tsg v9.2 rebased #15865
Conversation
…m caloStage2Params_2016_v3_1_cfi to v3_2.
A new Pull Request was created by @rekovic for CMSSW_8_1_X. It involves the following packages: L1Trigger/Configuration @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
+1 |
please test |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
This PR should not be difficult to review and merge, as it contains only one source code changed. |
@rekovic - did your data PR include |
@davidlange6 No, it did not. Instead, I made a PR for the data files which includes that file |
please test |
The tests are being triggered in jenkins. |
-1 Tested at: bafadb6 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals AddOn
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/step2_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log1306.0 step2 runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step2_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log10021.0 step2 runTheMatrix-results/10021.0_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017/step2_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017.log1330.0 step2 runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step2_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log135.4 step1 runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log25202.0 step2 runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log10024.0 step2 runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017.log
I found errors in the following addon tests: cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_PRef --relval 9000,50 --datatier "RAW" --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --magField 38T_PostLS1 --eventcontent RAW --fileout file:RelVal_Raw_PRef_DATA.root --filein /store/data/Run2016B/JetHT/RAW/v1/000/272/762/00000/C666CDE2-E013-E611-B15A-02163E011DBE.root : FAILED - time: date Fri Sep 16 00:45:09 2016-date Fri Sep 16 00:44:16 2016 s - exit: 23040 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
@davidlange6 src > pwd /afs/cern.ch/user/r/rekovic/release/CMSSW_8_1_X_2016-09-12-1100/src src > rm -r L1Trigger/L1TGlobal/data src > rm -r L1Trigger/L1TMuon/data src > rm -r L1Trigger/L1TCalorimeter/data , then cloning data files src > git clone git@github.com:cms-l1t-offline/L1Trigger-L1TGlobal.git ./L1Trigger/L1TGlobal/data Cloning into './L1Trigger/L1TGlobal/data'... remote: Counting objects: 59, done. remote: Total 59 (delta 0), reused 0 (delta 0), pack-reused 59 Receiving objects: 100% (59/59), 302.86 KiB | 0 bytes/s, done. Resolving deltas: 100% (28/28), done. src > git clone git@github.com:cms-l1t-offline/L1Trigger-L1TMuon.git ./L1Trigger/L1TMuon/data Cloning into './L1Trigger/L1TMuon/data'... remote: Counting objects: 3201, done. remote: Total 3201 (delta 0), reused 0 (delta 0), pack-reused 3201 Receiving objects: 100% (3201/3201), 3.18 MiB | 1.55 MiB/s, done. Resolving deltas: 100% (3010/3010), done. Checking out files: 100% (5610/5610), done. src > git clone git@github.com:cms-l1t-offline/L1Trigger-L1TCalorimeter.git ./L1Trigger/L1TCalorimeter/data Cloning into './L1Trigger/L1TCalorimeter/data'... remote: Counting objects: 132, done. remote: Compressing objects: 100% (11/11), done. remote: Total 132 (delta 5), reused 0 (delta 0), pack-reused 121 Receiving objects: 100% (132/132), 6.22 MiB | 6.07 MiB/s, done. Resolving deltas: 100% (45/45), done. ,the test run to completion, which otherwise were failing with jenkins. For example: src >cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_PRef --relval 9000,50 --datatier "RAW" --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --magField 38T_PostLS1 --eventcontent RAW --fileout file:RelVal_Raw_PRef_DATA.root --filein /store/data/Run2016B/JetHT/RAW/v1/000/272/762/00000/C666CDE2-E013-E611-B15A-02163E011DBE.root L1REPACK:Full,ENDJOB entry /store/data/Run2016B/JetHT/RAW/v1/000/272/762/00000/C666CDE2-E013-E611-B15A-02163E011DBE.root Step: L1REPACK Spec: ['Full'] L1T INFO: L1REPACK:Full (intended for 2016 data) will unpack all L1T inputs, re-emulated (Stage-2), and pack uGT, uGMT, and Calo Stage-2 output. L1TCalorimeter Sequence configured for Stage-2 (2016) trigger. L1TMuon Sequence configured for Stage-2 (2016) trigger. L1TGlobal Sequence configured for Stage-2 (2016) trigger. L1TCalorimeter Conditions configured for Stage-2 (2016) trigger. L1TMuon Conditions configured for Stage-2 (2016) trigger. L1TGlobal Conditions configured for Stage-2 (2016) trigger. L1Trigger/L1TGlobal/python/StableParameters_cff.py is deprecated, please use GlobalParameters_cff.py instead. Step: ENDJOB Spec: customising the process with L1T from HLTrigger/Configuration/CustomConfigs Starting cmsRun RelVal_L1REPACK.py L1T INFO: L1REPACK:Full (intended for 2016 data) will unpack all L1T inputs, re-emulated (Stage-2), and pack uGT, uGMT, and Calo Stage-2 output. L1TCalorimeter Sequence configured for Stage-2 (2016) trigger. L1TMuon Sequence configured for Stage-2 (2016) trigger. L1TGlobal Sequence configured for Stage-2 (2016) trigger. L1TCalorimeter Conditions configured for Stage-2 (2016) trigger. L1TMuon Conditions configured for Stage-2 (2016) trigger. L1TGlobal Conditions configured for Stage-2 (2016) trigger. L1Trigger/L1TGlobal/python/StableParameters_cff.py is deprecated, please use GlobalParameters_cff.py instead. %MSG-i ThreadSetup: (NoModuleName) 16-Sep-2016 08:15:07 CEST pre-events setting # threads 4 %MSG 16-Sep-2016 08:15:59 CEST Initiating request to open file root://eoscms.cern.ch//eos/cms/store/data/Run2016B/JetHT/RAW/v1/000/272/762/00000/C666CDE2-E013-E611-B15A-02163E011DBE.root 16-Sep-2016 08:16:02 CEST Successfully opened file root://eoscms.cern.ch//eos/cms/store/data/Run2016B/JetHT/RAW/v1/000/272/762/00000/C666CDE2-E013-E611-B15A-02163E011DBE.root Begin processing the 1st record. Run 272762, Event 41468301, LumiSection 51 at 16-Sep-2016 08:16:09.146 CEST Begin processing the 2nd record. Run 272762, Event 41669009, LumiSection 51 at 16-Sep-2016 08:16:09.147 CEST Begin processing the 3rd record. Run 272762, Event 41643921, LumiSection 51 at 16-Sep-2016 08:16:09.147 CEST ..... ============================================= MessageLogger Summary type category sev module subroutine count total ---- -------------------- -- ---------------- ---------------- ----- ----- 1 L1TGlobal -w L1TGlobalProduce 31 31 2 fileAction -s file_close 1 1 3 fileAction -s file_open 2 2 type category Examples: run/evt run/evt run/evt ---- -------------------- ---------------- ---------------- ---------------- 1 L1TGlobal 272762/41468301 272762/41643921 272762/41371262 2 fileAction PostEndRun 3 fileAction pre-events pre-events Severity # Occurrences Total Occurrences -------- ------------- ----------------- Warning 31 31 System 3 3 So this means to me that probably the data files have not made it yet into the release ? |
yes, I was confused about when this happened - looks like it happened for the 2300 IB last night. so we can retest soon |
please test |
The tests are being triggered in jenkins. |
+1 |
This is the PR for tag l1t-tsg-v9.2 of L1T offline code.
This PR is rebased on CMSSW_8_1_X with l1t-tsg-v9.-