Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly set matplotlib.use to avoid incorrect defaults #15937

Merged
merged 1 commit into from Sep 22, 2016

Conversation

Dr15Jones
Copy link
Contributor

The matplotlib external for CMSSW does not have a usable default
for the renderer for matplotlib. To work around the problem one
can explicit set a renderer to use.

The matplotlib external for CMSSW does not have a usable default
for the renderer for matplotlib. To work around the problem one
can explicit set a renderer to use.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_1_X.

It involves the following packages:

FWCore/Concurrency

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit, @wmtan this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@Dr15Jones
Copy link
Contributor Author

+1

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 21, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15312/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor

-1

Tested at: cd16e7a

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
d3673cc
f07cdcd
e177082
e3aa8c6
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15937/15312/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15937/15312/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15937/15312/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

  • Build:

I found an error when building:

Entering library rule at src/DQMServices/FwkIO/plugins
Entering library rule at src/DQMServices/FwkIO/test
Entering library rule at DQMServices/Diagnostic
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-09-21-1100/src/DQMServices/Diagnostic/bin/MakeDeanHTML.cc 
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-09-21-1100/src/IOMC/ParticleGuns/src/BaseRandomtXiGunProducer.cc: In member function 'virtual void edm::BaseRandomtXiGunProducer::endRunProduce(edm::Run&, const edm::EventSetup&)':
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-09-21-1100/src/IOMC/ParticleGuns/src/BaseRandomtXiGunProducer.cc:87:24: error: no matching function for call to 'edm::Run::put(std::auto_ptr&)'
    run.put( genRunInfo );
                        ^
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-09-21-1100/src/IOMC/ParticleGuns/src/BaseRandomtXiGunProducer.cc:12:0:
/cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_1_X_2016-09-21-1100/src/FWCore/Framework/interface/Run.h:111:5: note: candidate: template void edm::Run::put(std::unique_ptr<_Tp>)
     put(std::unique_ptr product) {put(std::move(product), std::string());}

  • Clang:

I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 48 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

/cvmfs/cms-ib.cern.ch/2016-39/slc6_amd64_gcc530/external/gcc/5.3.0/lib/gcc/x86_64-pc-linux-gnu/5.3.0/../../../../include/c++/5.3.0/bits/atomic_base.h:157:26: note: expanded from macro 'ATOMIC_FLAG_INIT'
#define ATOMIC_FLAG_INIT { 0 }
                         ^~~~~
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-09-21-1100/src/DQM/DTMonitorClient/src/DTRunConditionVarClient.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-09-21-1100/src/DQM/DTMonitorClient/src/DTLocalTriggerLutTest.cc 
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-09-21-1100/src/IOMC/ParticleGuns/src/BaseRandomtXiGunProducer.cc:87:8: error: no matching member function for call to 'put'
   run.put( genRunInfo );
   ~~~~^~~
/cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_1_X_2016-09-21-1100/src/FWCore/Framework/interface/Run.h:111:5: note: candidate template ignored: could not match 'unique_ptr' against 'auto_ptr'
    put(std::unique_ptr product) {put(std::move(product), std::string());}
    ^


The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
d3673cc
f07cdcd
e177082
e3aa8c6
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15937/15312/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15937/15312/git-merge-result

@Dr15Jones
Copy link
Contributor Author

The build failure has nothing to do with this pull request.

@davidlange6 davidlange6 merged commit 2a74fcb into cms-sw:CMSSW_8_1_X Sep 22, 2016
@Dr15Jones Dr15Jones deleted the forceMatplotlibUsage branch November 9, 2016 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants