l1 track trigger rebased

[davidlange6]

#15691 rebased

[davidlange6]

please test

[cmsbuild]

A new Pull Request was created by @davidlange6 (David Lange) for CMSSW_8_1_X.

It involves the following packages:

L1Trigger/TrackTrigger
SimTracker/TrackTriggerAssociation

@civanch, @mdhildreth, @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @sdevissc, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @threus, @dgulhan this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15329/console
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15336/console

[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[cmsbuild]

-1

Tested at: 16c2e88

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
16c2e88
b3b2927
32aa974
86cd2d7
2a74fcb
4cb6067
a8f1736
7b0273f
9a41e0f
b15b24a
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15949/15336/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15949/15336/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15949/15336/summary.html

I found follow errors while testing this PR

Failed tests: Build

• Build:

I found an error when building:

zUMLChi2Fit.cpp:(.text.startup+0xa90): undefined reference to `fwlite::Event::operator++()'
zUMLChi2Fit.cpp:(.text.startup+0xaf7): undefined reference to`fwlite::ErrorThrower::errorThrowerProductNotFoundException(std::type_info const&, char const_, char const_, char const_)'
zUMLChi2Fit.cpp:(.text.startup+0xb30): undefined reference to `fwlite::ErrorThrower::errorThrowerBranchNotFoundException(std::type_info const&, char const_, char const_, char const_)'
zUMLChi2Fit.cpp:(.text.startup+0xbbb): undefined reference to `fwlite::Event::~Event()'
zUMLChi2Fit.cpp:(.text.startup+0x6f38): undefined reference to`fwlite::Event::~Event()'
collect2: error: ld returned 1 exit status
>> Deleted: tmp/slc6_amd64_gcc530/src/ElectroWeakAnalysis/ZMuMu/bin/zUMLChi2Fit/zUMLChi2Fit
gmake: **\* [tmp/slc6_amd64_gcc530/src/ElectroWeakAnalysis/ZMuMu/bin/zUMLChi2Fit/zUMLChi2Fit] Error 1
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-09-21-2300/src/CalibTracker/SiStripChannelGain/plugins/SiStripGainCosmicCalculator.cc 
Copying tmp/slc6_amd64_gcc530/src/ElectroWeakAnalysis/ZMuMu/bin/zChi2Fit/zChi2Fit to productstore area:
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-09-21-2300/src/CalibTracker/SiStripChannelGain/plugins/SiStripGainRandomCalculator.cc 


The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
16c2e88
b3b2927
32aa974
86cd2d7
2a74fcb
4cb6067
a8f1736
7b0273f
9a41e0f
b15b24a
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15949/15336/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15949/15336/git-merge-result

[davidlange6]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15348/console
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15349/console

[cmsbuild]

+1
Tested at: 16c2e88
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15949/15348/summary.html

[cmsbuild]

+1
Tested at: 16c2e88
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15949/15349/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15949/15349/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• 10424.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017NewFPix_GenSimFull+DigiFull_2017NewFPix+RecoFull_2017NewFPix+HARVESTFull_2017NewFPix

[slava77]

it looks like changes in this PR SimTracker/TrackTriggerAssociation/src/classes_def.xml
are the reason for many issues with dictionary locations from the dictionary checker (duplicateReflexLibrarySearch.py --dir ./ --lostDefs )
At a first glance it also looks like a number of dictionaries are duplicates in addition to be misplaced
(like Ref for TrackingParticle or a dict for map

[sviret]

@slava77 I guess that I can indeed remove the TrackingParticle related dict from there (they were already there before). For the rest it's more complicated, as these are the dictionaries for the L1Tracking associator class. I don't think that they are defined anywhere else.

[smuzaffar]

@sviret

edm::Ptr< TrackingParticle >
vector< edm::Ptr< TrackingParticle > >

should move to SimDataFormats/TrackingAnalysis. For the rest, I can update the duplicate dict checker script to match

TTClusterAssociationMap
TTStubAssociationMap
(TTStub|TTCluster).*edm::refhelper::FindForDetSetVector.*Phase2TrackerDigi.*

for SimTracker/TrackTriggerAssociation.

[sviret]

@smuzaffar , OK thanks for the reply, I will move the TrackingParticle stuff in my next L1Tracking PR, which is planned for this week

[smuzaffar]

@sviret , this is still not fixed. Dictionary checking tests are still reporting these
https://cmssdt.cern.ch/SDT/cgi-bin/showDupDict.py//slc6_amd64_gcc530/www/sun/8.1-sun-23/CMSSW_8_1_X_2016-11-13-2300/testLogs/dupDict-lostDefs.log

[sviret]

@smuzaffar sorry about the delay, definitely no time available to work on that currently. Will look back at this in December