Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alignment validation bugfixes #16020

Merged
merged 5 commits into from Oct 4, 2016
Merged

alignment validation bugfixes #16020

merged 5 commits into from Oct 4, 2016

Conversation

hroskes
Copy link
Contributor

@hroskes hroskes commented Sep 28, 2016

Backport of #16019

On top of #15887 to avoid merge conflict

  • Error message was in a function that never got called, so it would just proceed silently and ignore firstRun and lastRun. This bit several people.
  • Also was missing .oO[Alignment/OfflineValidation]Oo. in creating the parallel jobs merge script repmap, need to apply PlottingOptions to get it.

@cmsbuild cmsbuild added this to the Next CMSSW_8_0_X milestone Sep 28, 2016
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @hroskes (Heshy Roskes) for CMSSW_8_0_X.

It involves the following packages:

Alignment/HIPAlignmentAlgorithm
Alignment/OfflineValidation

@ghellwig, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@mschrode, @ghellwig, @mmusich, @tocheng, @tlampen this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@hroskes hroskes changed the title Fix error message alignment validation bugfixes Sep 28, 2016
@mmusich
Copy link
Contributor

mmusich commented Sep 29, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 29, 2016 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15441/console

@ghellwig
Copy link

+1
provided jenkins agrees

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

+1
Tested at: 2cba4fe
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16020/15441/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16020/15441/summary.html

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c096d09 into cms-sw:CMSSW_8_0_X Oct 4, 2016
@hroskes hroskes deleted the fix-error-message branch October 4, 2016 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved backport comparison-available fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_8_0_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hroskes @cmsbuild @mmusich @ghellwig @davidlange6