Fix for Puppi MET and MET significance compatibility between AOD and miniAOD #16140

mmarionncern · 2016-10-07T13:17:57Z

This PR improves the coherence between what is done for Puppi MET and the MET significance calculation at the miniAOD production level and recomputation on top of miniAODs.

Packages touched :

PhysicsTools/PatAlgos
PhysicsTools/PatUtils
RecoMET/METAlgorithms
RecoMET/METProducers

Changes :

fix scheduled mode (do not affect unscheduled mode)
change the constructor of MET in the RecoMET extractor to copy properly the sumET from the slimmedMET collection when updating a miniAOD
MET significance computation at the AOD level updated to match the miniAOD level
Update of the test cfg files
fix the puppi JEC and the use of slimmedJetPuppi when recomputing the puppiMET from miniAOD
modify the MET signifiance code to match by reference the pfCandidates to the jets/lepton constituents + use of an extra recovery by delta"4Vector" matching when reference matching is failing

Expected changes in data file contents :

small changes in the mET signifiance when producing miniAOD
puppi MET values when rerunning on miniAOD
storage of the sumEt when recomputing MET on top of miniAOD

Conflicts: PhysicsTools/PatAlgos/test/corMETFromMiniAOD.py

cmsbuild · 2016-10-07T13:18:14Z

A new Pull Request was created by @mmarionncern for CMSSW_8_1_X.

It involves the following packages:

PhysicsTools/PatAlgos
PhysicsTools/PatUtils
RecoMET/METAlgorithms
RecoMET/METProducers

@cmsbuild, @cvuosalo, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @imarches, @ahinzmann, @acaudron, @gpetruc, @rappoccio, @jdolen, @nhanvtran, @JyothsnaKomaragiri, @gkasieczka, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

slava77 · 2016-10-07T13:22:17Z

@mmarionncern please change the title of the PR to describe what it does
"Mm fix schedule 230916" is not acceptable

slava77 · 2016-10-07T13:29:04Z

@cmsbuild please test

cmsbuild · 2016-10-07T13:29:18Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15593/console

cmsbuild · 2016-10-07T15:01:56Z

+1
Tested at: a578f10
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16140/15593/summary.html

mmarionncern · 2016-10-07T15:19:01Z

@slava77 sorry for the title, I did not noticed it, corrected

cmsbuild · 2016-10-07T16:14:32Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16140/15593/summary.html

cmsbuild · 2016-10-18T09:13:34Z

Pull request #16140 was updated. @cmsbuild, @cvuosalo, @slava77, @monttj, @davidlange6 can you please check and sign again.

mmarionncern · 2016-10-18T09:32:14Z

@slava77 the puppiMET is impacted when re-running the algorithm on miniAOD, I will clarify it in the description.

mmarionncern · 2016-10-18T10:05:08Z

@slava77 MET significance should increase a bit when producing miniAODs

cmsbuild · 2016-10-18T10:07:05Z

Pull request #16140 was updated. @cmsbuild, @cvuosalo, @slava77, @monttj, @davidlange6 can you please check and sign again.

slava77 · 2016-10-18T12:14:03Z

On 10/18/16 3:05 AM, mmarionncern wrote:

@slava77 https://github.com/slava77 MET significance should increase a
bit when producing miniAODs

Is it because of statistical redefinition of significance in this PR?
If MET is the same, what are the components that lead to increase of
significance?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#16140 (comment), or
mute the thread
https://github.com/notifications/unsubscribe-auth/AEdcbpMd735jhrR7xZhyPI90tgHT1rjUks5q1JnWgaJpZM4KRBLm.

cmsbuild · 2016-10-18T12:53:41Z

Pull request #16140 was updated. @cmsbuild, @cvuosalo, @slava77, @monttj, @davidlange6 can you please check and sign again.

slava77 · 2016-10-18T17:44:32Z

@cmsbuild please test

cmsbuild · 2016-10-18T17:44:44Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15800/console

slava77 · 2016-10-18T19:08:22Z

There is a visible increase in CPU time in MET modules with significance computation enabled:

relModule         relJob           baseline         ->      PR
   +0.789247      +0.10%         1.68 ms/ev ->         3.87 ms/ev patPFMetPuppi
   +0.053434      +0.02%         7.34 ms/ev ->         7.75 ms/ev patPFMet
   +0.647359      +0.08%         1.91 ms/ev ->         3.74 ms/ev patMETsPuppi
   +0.177489      +0.06%         6.58 ms/ev ->         7.87 ms/ev patMETs

this increase is small enough to be tolerated

cmsbuild · 2016-10-18T19:24:47Z

+1
Tested at: 5dabd0d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16140/15800/summary.html
Additional comment: 'materialbudget'

cmsbuild · 2016-10-18T20:43:50Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16140/15800/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

20024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D1_GenSimHLBeamSpotFull+DigiFull_2023D1+RecoFullGlobal_2023D1+HARVESTFullGlobal_2023D1
22424.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D3Timing_GenSimHLBeamSpotFull+DigiFull_2023D3Timing+RecoFullGlobal_2023D3Timing+HARVESTFullGlobal_2023D3Timing

slava77 · 2016-10-18T20:58:08Z

+1

for #16140 5dabd0d

code changes are in line with the description. A large fraction of the code changes is at analysis level (running on miniAOD inputs)
jenkins tests pass and comparisons show slight changes only in MET significance
local tests with 1K events using PAT step with ZEE ( 25200) and TTbar (25202) confirm observed differences in jenkins tests with higher precision. There are small variations in significance compared to Fix for Puppi MET and MET significance compatibility between AOD and miniAOD #16140 (comment) (there were some small logic changes in the last commits):

monttj · 2016-10-19T02:45:16Z

PhysicsTools/PatAlgos/python/producersLayer1/metProducer_cfi.py

@@ -49,7 +49,7 @@
    computeMETSignificance  = cms.bool(False),
    # significance computation parameters, not used
    # if the significance is not computed
-    srcJets = cms.InputTag("selectedPatJets"),
+    srcJets = cms.InputTag("cleanedPatJets"),


@mmarionncern

I am wondering what would be the motivation to switch to "cleanedPatJets" from "selectedPatJets"
and it dose not need to be the same jet collection as we save at the end?

Regards,
Taejeong

Hi @mmarionncern, @monttj - is this issue resolved?

@davidlange6 that change is validated for the MET group, waiting for @monttj red/green light on the explanation provided

mmarionncern · 2016-10-19T07:20:03Z

@slava77 >> Is it because of statistical redefinition of significance in this PR? If MET is the same, what are the components that lead to increase of significance?

This comes from the way the event components used in the covariance matrix computation (lepton, jets, unclustered particles) are disentangled. Compared to the previous version, there is a recovery of some soft particles associated to the leptons that are now correctly taken out of the unclsutered component.

@monttj >> I am wondering what would be the motivation to switch to "cleanedPatJets" from "selectedPatJets"
and it dose not need to be the same jet collection as we save at the end?

The cleanPatJet collection is the collection used in all MET related computation (type1 correction, etc), as those jets are cleaned from the lepton overlaps and are consistent with the kinematic selection made for the type1MET jet selection. For consistency, one should use that collection for the MET significance computation.

slava77 · 2016-10-24T21:45:21Z

@monttj
are there remaining issues to address?
your signature is needed here.

davidlange6 · 2016-10-31T09:37:42Z

seems we should move forward on this one.

matthieu and others added 8 commits September 23, 2016 15:17

fix MET tool scheduled mode

812671d

puppi scheduled mode and the reclustering update

09d06f1

fix puppi met extraction

c20c54f

fixing scheduled mode type1 puppi corrections only setup

7539758

Conflicts: PhysicsTools/PatAlgos/test/corMETFromMiniAOD.py

updating the configuration for data

f0b79ce

Conflicts: PhysicsTools/PatAlgos/test/corMETFromMiniAOD.py

fix MET extractor for sumEt

69bc672

Update METsignficance pfcand-object matching

4abf246

cleaning

a578f10

cmsbuild added this to the Next CMSSW_8_1_X milestone Oct 7, 2016

cmsbuild added analysis-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Oct 7, 2016

cmsbuild added tests-started and removed tests-pending labels Oct 7, 2016

cmsbuild added tests-approved and removed tests-started labels Oct 7, 2016

mmarionncern changed the title ~~Mm fix schedule 230916~~ Fix for Puppi MET and MET significance compatibility between AOD and miniAOD Oct 7, 2016

cmsbuild added comparison-available and removed comparison-pending labels Oct 7, 2016

fix photon uncertainty collection

1281463

cmsbuild added comparison-pending tests-pending labels Oct 18, 2016

met sig matchng and scheduled mode

823b68e

use of handle product

5dabd0d

cmsbuild added tests-started and removed tests-pending labels Oct 18, 2016

cmsbuild added tests-approved and removed tests-started labels Oct 18, 2016

cmsbuild added comparison-available and removed comparison-pending labels Oct 18, 2016

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Oct 18, 2016

monttj reviewed Oct 19, 2016

View reviewed changes

davidlange6 merged commit a244399 into cms-sw:CMSSW_8_1_X Oct 31, 2016

kpedro88 mentioned this pull request Jun 19, 2017

import METSignificanceParams_Data when needed #19371

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix for Puppi MET and MET significance compatibility between AOD and miniAOD #16140

Fix for Puppi MET and MET significance compatibility between AOD and miniAOD #16140

mmarionncern commented Oct 7, 2016 •

edited

cmsbuild commented Oct 7, 2016

slava77 commented Oct 7, 2016

slava77 commented Oct 7, 2016

cmsbuild commented Oct 7, 2016 •

edited

cmsbuild commented Oct 7, 2016

mmarionncern commented Oct 7, 2016

cmsbuild commented Oct 7, 2016

cmsbuild commented Oct 18, 2016

mmarionncern commented Oct 18, 2016

mmarionncern commented Oct 18, 2016

cmsbuild commented Oct 18, 2016

slava77 commented Oct 18, 2016

cmsbuild commented Oct 18, 2016

slava77 commented Oct 18, 2016

cmsbuild commented Oct 18, 2016 •

edited

slava77 commented Oct 18, 2016

cmsbuild commented Oct 18, 2016

cmsbuild commented Oct 18, 2016

slava77 commented Oct 18, 2016

monttj Oct 19, 2016

davidlange6 Oct 26, 2016

mmarionncern Oct 27, 2016

mmarionncern commented Oct 19, 2016

slava77 commented Oct 24, 2016

davidlange6 commented Oct 31, 2016

Fix for Puppi MET and MET significance compatibility between AOD and miniAOD #16140

Fix for Puppi MET and MET significance compatibility between AOD and miniAOD #16140

Conversation

mmarionncern commented Oct 7, 2016 • edited

cmsbuild commented Oct 7, 2016

slava77 commented Oct 7, 2016

slava77 commented Oct 7, 2016

cmsbuild commented Oct 7, 2016 • edited

cmsbuild commented Oct 7, 2016

mmarionncern commented Oct 7, 2016

cmsbuild commented Oct 7, 2016

cmsbuild commented Oct 18, 2016

mmarionncern commented Oct 18, 2016

mmarionncern commented Oct 18, 2016

cmsbuild commented Oct 18, 2016

slava77 commented Oct 18, 2016

cmsbuild commented Oct 18, 2016

slava77 commented Oct 18, 2016

cmsbuild commented Oct 18, 2016 • edited

slava77 commented Oct 18, 2016

cmsbuild commented Oct 18, 2016

cmsbuild commented Oct 18, 2016

slava77 commented Oct 18, 2016

monttj Oct 19, 2016

Choose a reason for hiding this comment

davidlange6 Oct 26, 2016

Choose a reason for hiding this comment

mmarionncern Oct 27, 2016

Choose a reason for hiding this comment

mmarionncern commented Oct 19, 2016

slava77 commented Oct 24, 2016

davidlange6 commented Oct 31, 2016

mmarionncern commented Oct 7, 2016 •

edited

cmsbuild commented Oct 7, 2016 •

edited

cmsbuild commented Oct 18, 2016 •

edited