Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Bits for 2017 HCAL HF TP #16156

Merged
merged 11 commits into from
Oct 18, 2016
Merged

Feature Bits for 2017 HCAL HF TP #16156

merged 11 commits into from
Oct 18, 2016

Commits on Oct 9, 2016

  1. Initial hookup of the DB parameters.

    @matz-e
    matz-e committed Oct 9, 2016
    Configuration menu
    Copy the full SHA
    4032961 View commit details
    Browse the repository at this point in the history

  2. Use a PSet to overwrite parameters. 

    Allows for finer-grain overwriting, and still taking some parameters from
the database.
    @matz-e
    matz-e committed Oct 9, 2016
    Configuration menu
    Copy the full SHA
    d8551c5 View commit details
    Browse the repository at this point in the history

  3. Don't use DB parameters for the FG algo before 2017.

    @matz-e
    matz-e committed Oct 9, 2016
    Configuration menu
    Copy the full SHA
    9a4ef3a View commit details
    Browse the repository at this point in the history

  4. Fix variable name.

    @matz-e
    matz-e committed Oct 9, 2016
    Configuration menu
    Copy the full SHA
    f2911cc View commit details
    Browse the repository at this point in the history

  5. Fix shifting too little.

    @matz-e
    matz-e committed Oct 9, 2016
    Configuration menu
    Copy the full SHA
    31e0c3a View commit details
    Browse the repository at this point in the history

  6. Check channel validity when adding signal.

    @matz-e
    matz-e committed Oct 9, 2016
    Configuration menu
    Copy the full SHA
    25fb1d1 View commit details
    Browse the repository at this point in the history

  7. Add MinBias Fine-Grain bit for 2017.

    @matz-e
    matz-e committed Oct 9, 2016
    Configuration menu
    Copy the full SHA
    521394e View commit details
    Browse the repository at this point in the history

  8. Refactor the HCAL HF EM bit. 

    Simplify code; Don't de- and then re-construct a dataframe, just pass it
through.  Unify the energy reconstruction in preparation for dual-anode
readout.
    @matz-e
    matz-e committed Oct 9, 2016
    Configuration menu
    Copy the full SHA
    0a3d7c0 View commit details
    Browse the repository at this point in the history

  9. Adjust EM bit to work with 2017 TP.

    @matz-e
    matz-e committed Oct 9, 2016
    Configuration menu
    Copy the full SHA
    0976b90 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2016

  1. Replace magic number with constant.

    @matz-e
    matz-e committed Oct 17, 2016
    Configuration menu
    Copy the full SHA
    25198a6 View commit details
    Browse the repository at this point in the history

  2. Don't query PSet in a loop over digis.

    @matz-e
    matz-e committed Oct 17, 2016
    Configuration menu
    Copy the full SHA
    0aa4ed8 View commit details
    Browse the repository at this point in the history