fix hitpattern for gem and me0

[jshlee]

gem and me0 hits were not added to hitpattern.

@calabria, @kpedro88

[cmsbuild]

A new Pull Request was created by @jshlee (Jason Lee) for CMSSW_8_1_X.

It involves the following packages:

RecoMuon/TrackingTools

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@bellan, @abbiendi, @jhgoh, @calderona, @HuguesBrun, @battibass, @trocino, @bachtis, @rociovilar this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[kpedro88]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15697/console

[cmsbuild]

+1
Tested at: 27eea45
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16195/15697/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16195/15697/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• 10021.0_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017
• 10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017
• 10424.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017NewFPix_GenSimFull+DigiFull_2017NewFPix+RecoFull_2017NewFPix+ALCAFull_2017NewFPix+HARVESTFull_2017NewFPix
• 10624.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017HCALdev_GenSimFull+DigiFull_2017HCALdev+RecoFull_2017HCALdev+ALCAFull_2017HCALdev+HARVESTFull_2017HCALdev
• 10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017AllNew_GenSimFull+DigiFull_2017AllNew+RecoFull_2017AllNew+ALCAFull_2017AllNew+HARVESTFull_2017AllNew

[cvuosalo]

Jenkins DQM results for workflow 22424.0 seem to show a global muon disappearing with this PR, which doesn't seem to make sense if missing hits are being recovered. Jenkins tests have low statistics, so an additional test with higher statistics will be done.

[jshlee]

@cvuosalo - this doesnt make sense since this PR shouldnt change global muons. I'll check it out.

[cvuosalo]

A test of workflow 22424.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D3Timing with 120 events against baseline CMSSW_8_1_0_pre12 gives the following plots. The first shows the loss of a few muons. The other two plots may or may not reflect the intended effects of this PR.

Missing muons:

Change in rec hit distribution:

Addition of GEM hits?

[jshlee]

@cvuosalo - I had a check and the number for global muons doesn't change. If you compare all the other plots in Muons_globalMuons_GeneralProperties, they are the same except for the plots that contain NumberOfRecHitsPerTrack. The NumberOfRecHitsPerTrack is currently capped at 40 hits. We should increase this to at least 60.

[cvuosalo]

+1

For #16195 27eea45

Fixing hits for GEMs and ME0 that were missing.

The code changes are satisfactory. Jenkins tests against baseline CMSSW_8_1_X_2016-10-12-1100 show differences that are expected from this PR, as discussed above. A test of workflow 22424.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D3Timing with 120 events against baseline CMSSW_8_1_0_pre12 also shows similar differences.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

[davidlange6]

+1