Phase 1 HBHE fixes related to SiPM nonlinearity and cosmic run mode

[igv4321]

Added the capability to disable "pulse containment correction". Will do this for Method 0 in the cosmic run mode.
Finer control over RecHit flags -- enable some legacy flags for QIE8 (but not HBHETriangleNoise).
Ready for the new SiPM nonlinearity correction (will need another minimal change after PR #16070 is integrated).
Bug fix: always retrieve HcalRecoParams from the database because it is needed unconditionally for determining "pulseShapeID".
This PR is not supposed to change any results apart from the HBHERecHit noise flags (for MC, may be not even that).

[cmsbuild]

A new Pull Request was created by @igv4321 (Igor Volobouev) for CMSSW_8_1_X.

It involves the following packages:

RecoLocalCalo/HcalRecAlgos
RecoLocalCalo/HcalRecProducers

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@mariadalfonso, @argiro this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[kpedro88]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15709/console

[cmsbuild]

+1
Tested at: f49af13
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16197/15709/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16197/15709/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• 10021.0_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017
• 10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017
• 10424.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017NewFPix_GenSimFull+DigiFull_2017NewFPix+RecoFull_2017NewFPix+ALCAFull_2017NewFPix+HARVESTFull_2017NewFPix
• 10624.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017HCALdev_GenSimFull+DigiFull_2017HCALdev+RecoFull_2017HCALdev+ALCAFull_2017HCALdev+HARVESTFull_2017HCALdev
• 10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017AllNew_GenSimFull+DigiFull_2017AllNew+RecoFull_2017AllNew+ALCAFull_2017AllNew+HARVESTFull_2017AllNew

[kpedro88]

@slava77 @cvuosalo @davidlange6 please review/approve, other PRs waiting on this one

[slava77]

@cmsbuild please test
to pick up comparisons in 2017

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15812/console

[slava77]

@igv4321 @kpedro88
it looks like code in this PR depends on #16070 (it temporarily reimplements parts of the code from that PR).

What is the status of #16070?

[slava77]

... I guess, incrementally, it's better for this PR to be in first, and then after #16070 is in, its nontrivial features can be picked up here

[cmsbuild]

-1

Tested at: f49af13

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16197/15812/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following worklfows:
4.22 step1

DAS Error

140.53 step1

DAS Error

1000.0 step1

DAS Error

1003.0 step1

DAS Error

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16197/15817/summary.html

[slava77]

@cmsbuild please test
comparisons still haven't showed up

@smuzaffar please check what was happening with
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15817/console
and an earlier
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15816/console
I've seen that the first one had https://cmssdt.cern.ch/jenkins/job/compare-root-files-short-matrix/16456/ complete OK, but the status page is showing "Running" for many hours since it did.

... I'll run the short matrix locally and signoff based on that

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15835/console

[cmsbuild]

+1
Tested at: f49af13
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16197/15835/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16197/15835/summary.html

[slava77]

+1

for #16197 f49af13

• code changes are in line with the description
• jenkins tests pass; the comparisons unfortunately never showed up
• local tests of short matrix as in jenkins show no differences , using CMSSW_8_1_X_2016-10-19-2300 as a baseline
• local tests of 2017 HCAL setup with PU35, Pi E 5 to 5000, and dijet 15 to 3 TeV show small changes only in TeV range of energies in Pion sample in HBHESpikeNoise flag in HB
  

the energy of the added hits is seen from the reducedhit energy distribution

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

[kpedro88]

@davidlange6 ping

[davidlange6]

+1