L1TGlobalPrescaler: additional modes based on the prescales in the EventSetup #16260
Conversation
…entSetup
- applyPrescaleValues: apply the given prescale values (original behaviour)
- applyPrescaleRatios: apply prescales equal to ratio between the given
values and the ones read from the EventSetup
- applyColumnValues: apply the prescale values from the EventSetup
corresponding to the given column index
- applyColumnRatios: apply prescales equal to ratio between the values
corresponsing to the given column index, and the
ones read from the EventSetup
In the last two cases, also sets the prescale column index to the given one.
|
A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_8_0_X. It involves the following packages: L1Trigger/L1TGlobal @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
please test |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: 055cf0b You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: DAS Error140.53 step1 DAS Error1000.0 step1 DAS Error1001.0 step1 DAS Error1003.0 step1 DAS Error |
|
This module is not used in any central workflow. |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison is ready The workflows 1003.0 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons |
|
+1 |
cmsbuild
added
fully-signed
l1-approved
and removed
l1-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
|
+1 |
Additional modes based on the prescales in the EventSetup:
In the last two cases, also sets the prescale column index to the given one.