Fix for warnings from static analyzer for data class const correctness #16281
Conversation
Geometry/VeryForwardGeometryBuilder/interface/TotemRPGeometry.h:80:5: warning: TotemRPGeometry::GetDetector is a const member function that returns a pointer or reference to a non-const object Geometry/VeryForwardGeometryBuilder/interface/TotemRPGeometry.h:82:5: warning: TotemRPGeometry::operator[] is a const member function that returns a pointer or reference to a non-const object
|
A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_8_1_X. It involves the following packages: Geometry/VeryForwardGeometryBuilder @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
please test |
|
This change is needed for thread-safety |
|
The tests are being triggered in jenkins. |
|
+1 |
cmsbuild
added
fully-signed
geometry-approved
and removed
geometry-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
|
Comparison job queued. |
|
+1 |
gartung
deleted the
Geometry-VeryForwardGeometryBuilder-clangSA-warning-fix
branch
https://cmssdt.cern.ch/SDT/jenkins-artifacts/ib-static-analysis/CMSSW_8_1_X_2016-10-19-2300/slc6_amd64_gcc530/llvm-analysis/report-5699da.html#EndPath
Geometry/VeryForwardGeometryBuilder/interface/TotemRPGeometry.h:80:5: warning: TotemRPGeometry::GetDetector is a const member function that returns a pointer or reference to a non-const object
Geometry/VeryForwardGeometryBuilder/interface/TotemRPGeometry.h:82:5: warning: TotemRPGeometry::operator[] is a const member function that returns a pointer or reference to a non-const object