Fix 'on demand' Service building #16290
Conversation
If a Service asks for another Service in its constructor and the second Service has not yet been created, the ServiceManager will create the second Service 'on demand'. Unfortunately, the on demand building was not running the ParameterSet validation code.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_1_X. It involves the following packages: FWCore/ServiceRegistry @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
cmsbuild
added
core-approved
fully-signed
tests-started
and removed
core-pending
pending-signatures
tests-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
|
-1 Tested at: 5187972 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests RelVals
I found errors in the following unit tests: ---> test testRecoMETMETProducers had ERRORS
When I ran the RelVals I found an error in the following worklfows: DAS Error140.53 step1 DAS Error1000.0 step1 DAS Error1001.0 step1 DAS Error1003.0 step1 DAS Error
There was error running material budget tests. The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
If a Service asks for another Service in its constructor and the
second Service has not yet been created, the ServiceManager will
create the second Service 'on demand'. Unfortunately, the on
demand building was not running the ParameterSet validation
code.