ME0 re-digitizer module

[dildick]

This module re-digitizes the ME0 pseudo digis. It smears and discretizes the timing position. It is included only in Phase2 digitization sequences.

Note: To be integrated after #16185. I will rebase on top of most recent build after #16185 is integrated.

[cmsbuild]

A new Pull Request was created by @dildick (Sven Dildick) for CMSSW_8_1_X.

It involves the following packages:

Configuration/Geometry
Configuration/PyReleaseValidation
Configuration/StandardSequences
DataFormats/GEMDigi
DataFormats/GEMRecHit
DataFormats/MuonDetId
Geometry/CMSCommonData
Geometry/GEMGeometry
Geometry/GEMGeometryBuilder
Geometry/MuonCommonData
Geometry/MuonNumbering
Geometry/MuonSimData
IOMC/RandomEngine
RecoLocalMuon/GEMSegment
RecoMuon/DetLayers
SimMuon/Configuration
SimMuon/GEMDigitizer
Validation/MuonGEMDigis

@smuzaffar, @civanch, @Dr15Jones, @dmitrijus, @cvuosalo, @ianna, @mdhildreth, @fabozzi, @cmsbuild, @srimanob, @franzoni, @slava77, @vanbesien, @hengne, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @wmtan, @makortel, @abbiendi, @GiacomoSguazzoni, @jhgoh, @VinInn, @Martin-Grunewald, @calderona, @HuguesBrun, @wddgit, @rovere, @ptcox, @battibass, @bellan, @trocino, @dgulhan, @bachtis, @rociovilar this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[slava77]

@dildick @pietverwilligen
should this PR supersede #16185 or should the merge of #16185 be removed from this PR?

[dildick]

I merged #16185 to test my code. The merge can be removed. I can also rebase after #16185 is merged.

[slava77]

-1
the PR looks premature

[cmsbuild]

Pull request #16354 was updated. @smuzaffar, @civanch, @Dr15Jones, @mdhildreth, @cmsbuild, @davidlange6 can you please check and sign again.

[dildick]

@slava77 It turns out that my additions do compile without #16185. I removed all #16185 commits.

[Dr15Jones]

+1
for Core, only added entry to RandomNumberService

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15980/console

[cmsbuild]

Pull request #16354 was updated. @smuzaffar, @civanch, @Dr15Jones, @mdhildreth, @cmsbuild, @davidlange6 can you please check and sign again.

[dildick]

ME0ReDigiProducer was not registered. I tested WFs 20024.0 and 22424.0 again. Both were successful.

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15992/console

[cmsbuild]

+1
Tested at: 619fb7f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16354/15992/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16354/15992/summary.html

[civanch]

+1

[dildick]

Hi, please let me know if more work is need for this PR. Thanks.

[Dr15Jones]

+1
Just adding another random number engine

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

[dildick]

Can this pull request be integrated, please? Thanks!

[davidlange6]

+1
though hopefully this module has a very short lifetime.