Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pr81x-HI-configurable CaloLayer2 emulator #16391

Conversation

rekovic
Copy link
Contributor

@rekovic rekovic commented Oct 30, 2016

This is 81x PR for L1T configurable emulation needed for 2016 HI run. (80x #16390)

  • Introduce configuration functionality for some parameters of CaloLayer2 emulator, suitable for 2016 HI running: jetBypassPUS, egHOverEcutBarrel, egHOverEcutEndcap, egBypassEGVetos. This is done via CaloParamsHelper class which ensures the backward compatibility of GlobalTags.
  • Introduce a new calo configuration file caloStage2Params_2016_v3_3_HI_cfi, which configures the above parameters as for HI run needs, but also changes the egShapeIdLUTFile to a DUMMY LUT effectively bypassing egShapeID cut in the EG Layer2 emulator.
  • Still keep the p-p default calo configuration in hackConditions as caloStage2Params_2016_v3_3_cfi. This will probably be changed to the v3_3_HI or similar, pending confirmation from the HI community.

…r2 emulator, suitable for HI running. (jetBypassPUS,egHOverEcutBarrel,egHOverEcutEndcap,egBypassEGVetos). Introduce a new calo configuration file caloStage2Params_2016_v3_3_HI_cfi and new customisation option --customiseSettings.L1TSettingsToCaloStage2Params_v3_3_HI to use it.
@rekovic
Copy link
Contributor Author

rekovic commented Oct 30, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 30, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16064/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rekovic for CMSSW_8_1_X.

It involves the following packages:

L1Trigger/Configuration
L1Trigger/L1TCalorimeter

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@rekovic
Copy link
Contributor Author

rekovic commented Oct 31, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@@ -1,6 +1,20 @@
import os.path
import FWCore.ParameterSet.Config as cms

def L1TSettingsToCaloStage2Params_v3_3_HI(process):
print " ##############################################################################"
print " # Loading configuration for calorimeter parameters for Heavy Ion run. #"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rekovic - time to start flushing out printouts from L1 configs - lets not introduce new ones. Thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I am removing printouts.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2016

Pull request #16391 was updated. @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please check and sign again.

@rekovic
Copy link
Contributor Author

rekovic commented Nov 2, 2016

+1

@rekovic
Copy link
Contributor Author

rekovic commented Nov 2, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16143/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6 davidlange6 merged commit 59dec3f into cms-sw:CMSSW_8_1_X Nov 2, 2016
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2016

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants