New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pr81x-HI-configurable CaloLayer2 emulator #16391
pr81x-HI-configurable CaloLayer2 emulator #16391
Conversation
…r2 emulator, suitable for HI running. (jetBypassPUS,egHOverEcutBarrel,egHOverEcutEndcap,egBypassEGVetos). Introduce a new calo configuration file caloStage2Params_2016_v3_3_HI_cfi and new customisation option --customiseSettings.L1TSettingsToCaloStage2Params_v3_3_HI to use it.
please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @rekovic for CMSSW_8_1_X. It involves the following packages: L1Trigger/Configuration @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
Comparison job queued. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
@@ -1,6 +1,20 @@ | |||
import os.path | |||
import FWCore.ParameterSet.Config as cms | |||
|
|||
def L1TSettingsToCaloStage2Params_v3_3_HI(process): | |||
print " ##############################################################################" | |||
print " # Loading configuration for calorimeter parameters for Heavy Ion run. #" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rekovic - time to start flushing out printouts from L1 configs - lets not introduce new ones. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. I am removing printouts.
Pull request #16391 was updated. @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please check and sign again. |
+1 |
please test |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
Comparison job queued. |
This is 81x PR for L1T configurable emulation needed for 2016 HI run. (80x #16390)
jetBypassPUS
,egHOverEcutBarrel
,egHOverEcutEndcap
,egBypassEGVetos
. This is done via CaloParamsHelper class which ensures the backward compatibility of GlobalTags.egShapeIdLUTFile
to a DUMMY LUT effectively bypassing egShapeID cut in the EG Layer2 emulator.