Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adedd Pixel Chip Capacitors materials to Phase II Pixel #16410

Merged
merged 1 commit into from Nov 2, 2016

Conversation

ghugo83
Copy link
Contributor

@ghugo83 ghugo83 commented Nov 1, 2016

@boudoul @VinInn @rovere @ebrondol @venturia @ianna @alkemyst

Phase II Outer Tracker plugged on Phase II Pixel :
The Sim Material Budget in CMSSW had not been compared with the Material Budget in tkLayout yet.

Using similar changes than few of the commits which were done in #16401 , I extended the material budget validation tools to Phase II D4, and then compared the results with tkLayout.

The results were not too bad for a first-time check, but still, I found some discrepancy between CMSSW Sim MB and tkLayout MB. This is shown by the plot :
comparison_tklayout_cmssw_sim

After some investigation, I found out that in one cfg file in tkLayout, the pixel chip capacitors materials is not assigned any CMSSW destination volume, whereas it should be added to the pixel description.

After doing the corresponding fix, I get a really good match between CMSSW and tkLayout, which tends to show this was the only significant issue.
The results are enclosed :
material_budget_tklayout_versus_cmssw_sim

Summary :
This PR adds Pixel Chip Capacitors materials to Phase II Pixel description, and provides a match between CMSSW sim MB and tkLayout MB.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2016

A new Pull Request was created by @ghugo83 for CMSSW_8_1_X.

It involves the following packages:

Geometry/TrackerCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @ghellwig, @VinInn, @venturia this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@civanch
Copy link
Contributor

civanch commented Nov 1, 2016

@ghudo83, why there are several identical material? Do we expect that these materials become different in future? In general, each new material bring an extra memory and CPU overhead, tiny but...

@ghugo83
Copy link
Contributor Author

ghugo83 commented Nov 1, 2016

Until now, there is one material mixture defined per tracker module. This is not necessary, it should be one material mixture defined per module type. You are totally right.
This was already discussed, and one of my next tasks is to reshape the code for the materials and their export in tkLayout. This is planned to be included in the changes (along with, notably, the introduction of the energy loss within tkLayout).

@civanch
Copy link
Contributor

civanch commented Nov 1, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16129/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2016

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2016

@ianna
Copy link
Contributor

ianna commented Nov 2, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 57e83a6 into cms-sw:CMSSW_8_1_X Nov 2, 2016
@ebrondol
Copy link
Contributor

ebrondol commented Nov 2, 2016

Näive question: do I understand correctly that since this is just for the Phase2 Pixel detector, it is not going to be propagated into PhaseII/TiltedTracker and PhaseII/FlatTracker?

@ghugo83
Copy link
Contributor Author

ghugo83 commented Nov 2, 2016

Geometry/TrackerCommonData/data/PhaseII/FlatTracker and Geometry/TrackerCommonData/data/PhaseII/TiltedTracker are as you know plugged on a Phase I Pixel, so are not concerned by this.

Today I will look at the Phase II OT which are in there and compare it with tkLayout as well. I will not look at the Phase I Pixel though.

@ebrondol
Copy link
Contributor

ebrondol commented Nov 2, 2016

Great, thanks for the clarification.

@venturia
Copy link
Contributor

venturia commented Nov 2, 2016

@ghugo83 would be able to produce the usual material vs eta plot, both with tkLayout and CMSSW, by selecting only a, let's say, cylinder with a given Rmax and Zmax ? This would allow you to do the comparison only in the pixel volume, up to the PS part of the barrel, for the whole tracker, ...

@ghugo83
Copy link
Contributor Author

ghugo83 commented Nov 2, 2016

yep sure, it is technically possible to look at the Pixel-only MB. This is even easy, because in the MB validation tool, you can select the LogicalVolume which one wants to isolate. For example, PixelBarrel and PixelForward.
I was just saying I will not look at the Phase I Pixel description, because it is not exported from tkLayout MB. But I can produce it for info as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants