New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bsunanda:Run2-alca71 Correct the o/p for AlCaReco stream #16436
Conversation
A new Pull Request was created by @bsunanda for CMSSW_8_1_X. It involves the following packages: Calibration/HcalAlCaRecoProducers @ghellwig, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
@cmsbuild Please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
@mmusich Please approve this |
@@ -11,14 +11,17 @@ | |||
outputCommands = cms.untracked.vstring( | |||
'keep *_IsoProd_*_*', | |||
'keep *_TkAlIsoProd_*_*', | |||
'keep *_hbhereco_*_*', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmusich I can have a look. Which of these input datasets is best suited for such a test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The output from previous output command was not useful for calibration purpose. This will increase the o/p but the trigger rate is small enough
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bsunanda right, still it would be good to have at least qualitatively a measure of it. how urgent is this? 2016 pp data-taking is over.
@ghellwig, unfortunately none of those:
https://github.com/cms-sw/cmssw/blob/CMSSW_8_1_X/Configuration/AlCa/python/autoAlca.py#L3
on data this is run on the Commissioning PD (we'll need to see if there is any RAW around)
@mmusich Please approve this |
@mmusich Please approve this PR |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
+1 |
No description provided.