Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bsunanda:Run2-alca71 Correct the o/p for AlCaReco stream #16436

Merged
merged 1 commit into from Nov 11, 2016

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Nov 2, 2016

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2016

A new Pull Request was created by @bsunanda for CMSSW_8_1_X.

It involves the following packages:

Calibration/HcalAlCaRecoProducers
Calibration/HcalCalibAlgos

@ghellwig, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @tocheng this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@bsunanda
Copy link
Contributor Author

bsunanda commented Nov 2, 2016

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16155/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2016

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2016

@bsunanda
Copy link
Contributor Author

bsunanda commented Nov 3, 2016

@mmusich Please approve this

@@ -11,14 +11,17 @@
outputCommands = cms.untracked.vstring(
'keep *_IsoProd_*_*',
'keep *_TkAlIsoProd_*_*',
'keep *_hbhereco_*_*',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsunanda how much more data do we expect from this change?

@ghellwig: would it be possible to check using wf 1000.0 the expected output file change?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmusich I can have a look. Which of these input datasets is best suited for such a test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The output from previous output command was not useful for calibration purpose. This will increase the o/p but the trigger rate is small enough

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsunanda right, still it would be good to have at least qualitatively a measure of it. how urgent is this? 2016 pp data-taking is over.

@ghellwig, unfortunately none of those:
https://github.com/cms-sw/cmssw/blob/CMSSW_8_1_X/Configuration/AlCa/python/autoAlca.py#L3
on data this is run on the Commissioning PD (we'll need to see if there is any RAW around)

@bsunanda
Copy link
Contributor Author

bsunanda commented Nov 8, 2016

@mmusich Please approve this

@bsunanda
Copy link
Contributor Author

@mmusich Please approve this PR

@mmusich
Copy link
Contributor

mmusich commented Nov 10, 2016

+1
though @bsunanda I have not seen updates on #16436 (comment). Also the urgency of this has not been clarified.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit efa9ca8 into cms-sw:CMSSW_8_1_X Nov 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants