Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged pixelRecoMaterial.xml and trackerRecoMaterial.xml into one file #16547

Merged
merged 2 commits into from Nov 10, 2016

Conversation

ghugo83
Copy link
Contributor

@ghugo83 ghugo83 commented Nov 10, 2016

As requested by @rovere , pixelRecoMaterial.xml and trackerRecoMaterial.xml are merged into one file, called trackerRecoMaterial.xml .

This also contains :

  • Update tracking groups names within trackerRecoMaterial.xml (names relevant for PhaseII)
  • Update tracking groups names in SimTracker/TrackerMaterialAnalysis accordingly

@rovere , if you could please cross-check and potentially let me know/update in case I forgot anything,
Thanks,
Cheers,
Gabrielle

…e (trackerRecoMaterial.xml) + Deleted references to pixelRecoMaterial.xml + Updated tracking groups names.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ghugo83 for CMSSW_8_1_X.

It involves the following packages:

Configuration/Geometry
Geometry/CMSCommonData
Geometry/TrackerRecoData
SimTracker/TrackerMaterialAnalysis

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @sdevissc, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @threus, @dgulhan this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@ianna
Copy link
Contributor

ianna commented Nov 10, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 10, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16298/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@ianna
Copy link
Contributor

ianna commented Nov 10, 2016

+1

@civanch
Copy link
Contributor

civanch commented Nov 10, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 239ed90 into cms-sw:CMSSW_8_1_X Nov 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants