Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close the socket after it is used in StatisticsSenderService #16550

Merged
merged 1 commit into from Nov 11, 2016
Merged

Close the socket after it is used in StatisticsSenderService #16550

merged 1 commit into from Nov 11, 2016

Conversation

Dr15Jones
Copy link
Contributor

The StatisticsSenderService was opening a socket each time a file
closed but did not close it. This eventually lead to jobs with
many files to run out of file descriptors.

@Dr15Jones
Close the socket after it is used in StatisticsSenderService
9d7d693 
The StatisticsSenderService was opening a socket each time a file
closed but did not close it. This eventually lead to jobs with
many files to run out of file descriptors.
@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild cmsbuild added this to the Next CMSSW_8_0_X milestone Nov 10, 2016
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 10, 2016 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16303/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_0_X.

It involves the following packages:

Utilities/StorageFactory

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@Dr15Jones
Copy link
Contributor Author

backport #16543

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

+1
Tested at: 9d7d693
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16550/16303/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16550/16303/summary.html

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6254c7d into cms-sw:CMSSW_8_0_X Nov 11, 2016
@Dr15Jones Dr15Jones deleted the closeSocket_8_0 branch November 14, 2016 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport comparison-available core-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_8_0_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Dr15Jones @cmsbuild @davidlange6