Update SiPM parameters and fix a few bugs in hardcode conditions #16607
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The major change in this PR is new SiPM parameters (gain, photoelectronsToAnalog, dark current, crosstalk). We were informed about a month ago by the hardware experts that the SiPMs were run with an effective overvoltage of ~4.4V during test beam, but subsequent studies found that an overvoltage of 3V maximized signal to noise. Many SiPM parameters depend on voltage, so they need to be updated from the initial testbeam analysis to get better agreement with expected running conditions.
We were sent some pedestal runs from b904, which I analyzed (with the help of numerous experts) to get an average set of parameters. Slides detailing this analysis can be found here: sipm_condition_analysis.pdf.
I also fixed a few minor bugs:
@abdoulline, I hope we can update all the database conditions at once...
@lihux25, it might be necessary to recheck the ZS thresholds with the new parameters. I would suggest not rerunning the whole study, but just check the existing "best" threshold you found, and then a slightly higher or lower value (to see how things change). To use the hardcode conditions in your config, merge this PR (in any recent IB) and then:
Automatically ported from CMSSW_8_1_X #16526 (original by @kpedro88).