Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete customize cust_2023tilted from 2023D6 workflows #16682

Merged
merged 1 commit into from Nov 22, 2016

Conversation

makortel
Copy link
Contributor

Title says it all (commit picked from #16635).

The customize was removed in #16385, and the D6 workflows were added in #16185. I suspect their integration got somehow interleaved leading to the non-existing customize to stay in the workflow definition.

Tested in CMSSW_9_0_X_2016-11-17-2300, workflows 236xx run again.

@kpedro88 @pietverwilligen

I believe the cleanup of cust_2023tilted and the integration of D6
interleaved or something.
@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 18, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16459/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_9_0_X.

It involves the following packages:

Configuration/PyReleaseValidation

@cmsbuild, @srimanob, @davidlange6, @hengne, @fabozzi can you please review it and eventually sign? Thanks.
@ghellwig, @felicepantaleo, @Martin-Grunewald this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@makortel
Copy link
Contributor Author

type bugfix

@cmsbuild
Copy link
Contributor

-1

Tested at: 2961987

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16682/16459/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
21234.0 step2

runTheMatrix-results/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D4_GenSimHLBeamSpotFull+DigiFull_2023D4+RecoFullGlobal_2023D4+HARVESTFullGlobal_2023D4/step2_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D4_GenSimHLBeamSpotFull+DigiFull_2023D4+RecoFullGlobal_2023D4+HARVESTFullGlobal_2023D4.log
23234.0 step2
runTheMatrix-results/23234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D5_GenSimHLBeamSpotFull+DigiFull_2023D5+RecoFullGlobal_2023D5+HARVESTFullGlobal_2023D5/step2_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D5_GenSimHLBeamSpotFull+DigiFull_2023D5+RecoFullGlobal_2023D5+HARVESTFullGlobal_2023D5.log

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@makortel
Copy link
Contributor Author

Failures are already in the IB (not related to this PR).

@kpedro88
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 19, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16489/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16682/16489/summary.html

Alternative comparison was/were failed for workflow(s):
10021.0

@smuzaffar
Copy link
Contributor

@davidlange6 , this should fix the 4 failing relvals for IBs

23621.0_TenMuE_0_200+TenMuE_0_200_pythia8_2023D6_GenSimHLBeamSpotFull+DigiFull_2023D6+RecoFullGlobal_2023D6+HARVESTFullGlobal_2023D6 Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Tue Nov 22 08:26:53 2016-date Tue Nov 22 08:18:16 2016; exit: 0 0 0 0
23634.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D6_GenSimHLBeamSpotFull14+DigiFull_2023D6+RecoFullGlobal_2023D6+HARVESTFullGlobal_2023D6 Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Tue Nov 22 08:31:29 2016-date Tue Nov 22 08:18:21 2016; exit: 0 0 0 0
23646.0_ZEE_14+ZEE_14TeV_TuneCUETP8M1_2023D6_GenSimHLBeamSpotFull14+DigiFull_2023D6+RecoFullGlobal_2023D6+HARVESTFullGlobal_2023D6 Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Tue Nov 22 08:30:00 2016-date Tue Nov 22 08:18:22 2016; exit: 0 0 0 0
23653.0_QCD_Pt_600_800_14+QCD_Pt_600_800_14TeV_TuneCUETP8M1_2023D6_GenSimHLBeamSpotFull14+DigiFull_2023D6+RecoFullGlobal_2023D6+HARVESTFullGlobal_2023D6 Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Tue Nov 22 08:36:44 2016-date Tue Nov 22 08:18:27 2016; exit: 0 0 0 0
4 4 4 4 tests passed, 0 0 0 0 failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants