Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add eventSetupPathKey to ALCARECOLumiPixels #16684

Merged
merged 2 commits into from Nov 23, 2016

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Nov 18, 2016

This PR allows the possibility to steer the selection of the trigger bits populating the ALCARECOLumiPixels ALCARECO via TriggerBit stored in DB.

This should solve the issue with the problematic version of the trigger:
AlCa_PAL1MinimumBiasHF_OR_SinglePixelTrack_v1
creating events with event content not manageable by the ALCARECOLumiPixels reported in: HN link by filtering out the offending trigger with an appropriate DB payload.

Tested working via:

cmsrel CMSSW_8_0_24
cd CMSSW_8_0_24/src
git cms-init
git remote add cms-AlCaDB git@github.com:cms-AlCaDB/cmssw.git
git fetch cms-AlCaDB
git checkout 80X_addSetupPathKeyLumiPixels
git cms-addpkg Calibration/TkAlCaRecoProducers
git cms-addpkg Configuration/DataProcessing
scramv1 b -j 8
cd Configuration/DataProcessing/test/
python RunPromptReco.py --scenario AlCaLumiPixels --global-tag 80X_dataRun2_Prompt_v15 --lfn /store/hidata/PARun2016B/AlCaLumiPixels/RAW/v1/000/285/368/00000/7EC99302-E2AC-E611-A135-02163E01465B.root --reco --dqmio --alcarecos=LumiPixels
cmsRun RunPromptReco.py

attn: @trtomei @tocheng @capalmer85

@mmusich
Copy link
Contributor Author

mmusich commented Nov 18, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 18, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16470/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_8_0_X.

It involves the following packages:

Calibration/TkAlCaRecoProducers

@ghellwig, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @threus, @tocheng this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@capalmer85
Copy link
Contributor

@mmusich For pp running next year (2017), we do NOT want to use this trigger. Will we simply have it set to 0 all the time or will this be in a separate "branch" specific for HI development?

@mmusich
Copy link
Contributor Author

mmusich commented Nov 18, 2016

@capalmer85

we do NOT want to use this trigger. Will we simply have it set to 0 all the time or will this be in a separate "branch" specific for HI development

that's exactly what triggerbits in DB are meant for. Currently you were accepting everything in the PD...

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #16684 was updated. @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Nov 21, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 21, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16507/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@mmusich
Copy link
Contributor Author

mmusich commented Nov 21, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e9baaee into cms-sw:CMSSW_8_0_X Nov 23, 2016
@mmusich mmusich deleted the 80X_addSetupPathKeyLumiPixels branch April 22, 2022 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants