New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-add eventSetupPathKey to ALCARECOLumiPixels #16684
Re-add eventSetupPathKey to ALCARECOLumiPixels #16684
Conversation
please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_8_0_X. It involves the following packages: Calibration/TkAlCaRecoProducers @ghellwig, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
@mmusich For pp running next year (2017), we do NOT want to use this trigger. Will we simply have it set to 0 all the time or will this be in a separate "branch" specific for HI development? |
that's exactly what triggerbits in DB are meant for. Currently you were accepting everything in the PD... |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
+1 |
This PR allows the possibility to steer the selection of the trigger bits populating the
ALCARECOLumiPixels
ALCARECO via TriggerBit stored in DB.This should solve the issue with the problematic version of the trigger:
AlCa_PAL1MinimumBiasHF_OR_SinglePixelTrack_v1
creating events with event content not manageable by the
ALCARECOLumiPixels
reported in: HN link by filtering out the offending trigger with an appropriate DB payload.Tested working via:
attn: @trtomei @tocheng @capalmer85