Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[90X] Offline DQM modules for L1Trigger (stage2 calo layer2) #16704

Merged
merged 7 commits into from Mar 17, 2017

Conversation

kreczko
Copy link
Contributor

@kreczko kreczko commented Nov 21, 2016

This PR includes Offline DQM components for the Stage 2 Calo Layer 2.
In particular, this DQM focuses on energy sums and jets and their L1T-reco comparison including the L1T emulator.
Also included are the L1TEfficiencyHarvesting module, an improved copy of the now diverged L1TEfficiency_Harvesting module, and the L1TDiffHarvesting module for the comparison between L1T and emulator results. The plan is to reconcile the L1TEfficiencyHarvesting and L1TEfficiency_Harvesting modules into one in a future PR.

The PR has been tested on TTJet simulation

  • /RelValTTbarLepton_13/CMSSW_8_1_0_pre12-81X_mcRun2_asymptotic_v8-v1/GEN-SIM-RECO
  • /RelValTTbarLepton_13/CMSSW_8_1_0_pre12-81X_mcRun2_asymptotic_v8-v1/GEN-SIM-DIGI-RAW-HLTDEBUG)

but results from runTheMatrix.py -l limited -i all are still pending.

Edited blocks in python configs have been formatted according to PEP8 style guide.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kreczko (Luke Kreczko) for CMSSW_9_0_X.

It involves the following packages:

DQMOffline/Configuration
DQMOffline/L1Trigger

@dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@threus, @rociovilar this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@kreczko kreczko changed the title L1 stage2 calo layer2 offline Offline DQM modules for L1Trigger (stage2 calo layer2) Nov 21, 2016
@kreczko kreczko changed the title Offline DQM modules for L1Trigger (stage2 calo layer2) [90X] Offline DQM modules for L1Trigger (stage2 calo layer2) Nov 21, 2016
@kreczko
Copy link
Contributor Author

kreczko commented Nov 21, 2016

@cmsbuild please test

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 24, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16580/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@kreczko
Copy link
Contributor Author

kreczko commented Nov 24, 2016

@rekovic
Copy link
Contributor

rekovic commented Dec 14, 2016

+1

@rekovic
Copy link
Contributor

rekovic commented Mar 8, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18238/console Started: 2017/03/08 11:21

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2017

@rekovic
Copy link
Contributor

rekovic commented Mar 14, 2017

+1

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@dmitrijus
Copy link
Contributor

91x: #17734

@kreczko
Copy link
Contributor Author

kreczko commented Mar 15, 2017

@davidlange6 Since #17734 is now merged, can this be merged as well?

@davidlange6
Copy link
Contributor

davidlange6 commented Mar 15, 2017 via email

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants