-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[90X] Offline DQM modules for L1Trigger (stage2 calo layer2) #16704
[90X] Offline DQM modules for L1Trigger (stage2 calo layer2) #16704
Conversation
A new Pull Request was created by @kreczko (Luke Kreczko) for CMSSW_9_0_X. It involves the following packages: DQMOffline/Configuration @dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
@cmsbuild please test |
+1 |
The tests are being triggered in jenkins. |
Comparison job queued. |
@dmitrijus Should I expect to see the new DQM plots in this list? |
+1 |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
91x: #17734 |
@davidlange6 Since #17734 is now merged, can this be merged as well? |
once tested in 91x, then we will consider for 90x,yes
… On Mar 15, 2017, at 1:46 PM, Luke Kreczko ***@***.***> wrote:
@davidlange6 Since #17734 is now merged, can this be merged as well?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
+1 |
This PR includes Offline DQM components for the Stage 2 Calo Layer 2.
In particular, this DQM focuses on energy sums and jets and their L1T-reco comparison including the L1T emulator.
Also included are the
L1TEfficiencyHarvesting
module, an improved copy of the now divergedL1TEfficiency_Harvesting
module, and theL1TDiffHarvesting
module for the comparison between L1T and emulator results. The plan is to reconcile theL1TEfficiencyHarvesting
andL1TEfficiency_Harvesting
modules into one in a future PR.The PR has been tested on TTJet simulation
/RelValTTbarLepton_13/CMSSW_8_1_0_pre12-81X_mcRun2_asymptotic_v8-v1/GEN-SIM-RECO
/RelValTTbarLepton_13/CMSSW_8_1_0_pre12-81X_mcRun2_asymptotic_v8-v1/GEN-SIM-DIGI-RAW-HLTDEBUG
)but results from
runTheMatrix.py -l limited -i all
are still pending.Edited blocks in python configs have been formatted according to PEP8 style guide.