Phase2Digitizer package updated #16822
Conversation
…d properly for individual SimHit contributions to the Digi. There was a subtle bug that only the first EncodedEventId was stored. Another bug has also been fixed where the fraction of individual contribution to the digi was calculated wrongly. A few new histograms are added in the validation suite and a few minor bugs corrected.
|
@smuzaffar @iahmad-khan - seems this pull request did not get picked up by cmsbuild. can you have a look? |
|
A new Pull Request was created by @suchandradutta (Suchandra Dutta) for CMSSW_8_1_X. It involves the following packages: SimTracker/SiPhase2Digitizer @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
ok, seems I just needed to comment on the PR.. |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Should there be a 90X version of this PR? |
|
Hi @kpedro88 , right, we discussed this today during our tracker meeting, I was thinking that it was part of the one auto forward ported but likely it came after the auto forward port [was lost with my calendar, I thought it was in the 81X queue earlier] |
|
not needed in 81x. (phase2 dev will evolve in 90x) |
Updated DigitizerUtility::Amplitude object to store the EncodedEventId properly for individual SimHit contributions to the Digi. There was a subtle bug that only the first EncodedEventId was stored. Another bug has also been fixed where the fraction of individual contribution to the digi was calculated wrongly. A few new histograms are added in the validation suite and a few minor bugs corrected.
Detailed description of the update reported in Tracker Phase2 Simulation meeting can be found here
https://indico.cern.ch/event/536892/contributions/2385404/attachments/1379749/2096939/DigiStudy_Status_Nov29_2016.pdf
@delaere @atricomi @boudoul @emiglior