Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding hgcal era modifications #16904

Merged
merged 2 commits into from
Dec 13, 2016

Conversation

drankincms
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2016

A new Pull Request was created by @drankincms for CMSSW_9_0_X.

It involves the following packages:

DQMOffline/EGamma

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@rociovilar this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@kpedro88
Copy link
Contributor

kpedro88 commented Dec 7, 2016

@drankin, you should also activate the egamma DQM sequence for Phase2. I think you just need to add 'egamma' to the list here:
https://github.com/cms-sw/cmssw/blob/CMSSW_9_0_X/DQMOffline/Configuration/python/autoDQM.py#L56

Then the egamma DQM should automatically run in all phase2 workflows. This will let us see if it actually works.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2016

Pull request #16904 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again.

@kpedro88
Copy link
Contributor

kpedro88 commented Dec 7, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16849/console Started: 2016/12/07 23:20

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2016

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2016

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16904/16849/summary.html

The workflows 1003.0, 1001.0, 1000.0, 140.53, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

@kpedro88
Copy link
Contributor

@dmitrijus, @vanbesien please sign

@davidlange6 davidlange6 merged commit 2908752 into cms-sw:CMSSW_9_0_X Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants