Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lhe reader weights 53X #1695

Merged
merged 7 commits into from
Jan 16, 2014

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Dec 5, 2013

Backport of #1020 to 53X series

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2013

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_5_3_X.

Fix lhe reader weights 53X

It involves the following packages:

GeneratorInterface/LHEInterface
SimDataFormats/GeneratorProducts

@vciulli, @civanch, @nclopezo, @mdhildreth, @cmsbuild, @giamman can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@smuzaffar you are the release manager for this.

@vciulli
Copy link
Contributor

vciulli commented Jan 3, 2014

+1
tested on CMSSW_5_3_X_2014-01-03-0200

@vciulli
Copy link
Contributor

vciulli commented Jan 6, 2014

would it be possible to move on with this pull and approve it at the next ORP?

@smuzaffar

@bendavid
Copy link
Contributor

Hi,
Can we please get the remaining signatures on this one? (This is a backport of 70x feature to read lhe weights from madgraph/aMC@NLO lhe files with additional systematics)

@civanch
Copy link
Contributor

civanch commented Jan 14, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @smuzaffar can you please take care of it?

@davidlange6
Copy link
Contributor

+1
(indeed, these packages should not need a simulation signature)

@ktf
Copy link
Contributor

ktf commented Jan 15, 2014

Package is now under generators.

On 15 Jan 2014, at 12:39, davidlange6 wrote:

+1
(indeed, these packages should not need a simulation signature)


Reply to this email directly or view it on GitHub:
#1695 (comment)

@smuzaffar
Copy link
Contributor

+tested

smuzaffar added a commit that referenced this pull request Jan 16, 2014
@smuzaffar smuzaffar merged commit f4b1131 into cms-sw:CMSSW_5_3_X Jan 16, 2014
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants