RecoTracker/DebugTools: bug fix beginRun not called because of incorrect parameters

[gartung]

This fixes clang warning hides overloaded virtual function [-Woverloaded-virtual]by adding const to function declaration of beginRun. A potential bug fix because beginRun is now called where it was not before.

[cmsbuild]

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_9_0_X.

It involves the following packages:

RecoTracker/DebugTools

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @gpetruc, @dgulhan this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[cvuosalo]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16974/console Started: 2016/12/12 21:08

[cmsbuild]

+1
Tested at: 6441163
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16976/16974/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16976/16974/summary.html

[cvuosalo]

@rovere, @vincenzo: Are the contents of the RecoTracker/DebugTools even used anymore? Maybe we could just delete it rather than updating it?

[cvuosalo]

@gartung: If we don't delete the directory, please add override to ensure this problem doesn't happen silently again when the base signature changes.

[vincenzo]

@cvuosalo I think you got the wrong Vincenzo there. Kinda feel you wanted to tag @VinInn ;)

[cvuosalo]

@VinInn: Are the contents of the RecoTracker/DebugTools even used anymore? Maybe we could just delete it rather than updating it?

[cvuosalo]

@gartung: We might as well good ahead with this PR. Maybe some day in the future the whole directory can be deleted.
Please add override specifiers just as you've done in the other PRs.

[cmsbuild]

Pull request #16976 was updated. @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please check and sign again.

[cvuosalo]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17127/console Started: 2016/12/20 17:25

[cmsbuild]

+1
Tested at: 33b5f12
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16976/17127/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16976/17127/summary.html

[cvuosalo]

+1

For #16976 33b5f12

Fixing Clang warnings about overloading in RecoTracker/DebugTools. It is uncertain whether this directory is even used at all anymore. There should be no change in standard workflows.

In the future, we can consider deleting this directory entirely if the tracking group (and everyone else) doesn't object.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_9_0_X_2016-12-19-2300 show no significant differences, as expected.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

[davidlange6]

+1