Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FastTimerService - multithreading fixes part1 #1703

Merged
merged 8 commits into from Dec 7, 2013
Merged

FastTimerService - multithreading fixes part1 #1703

merged 8 commits into from Dec 7, 2013

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Dec 6, 2013

Migrate the FastTimerService to the new signals, even though it is not fully thread-safe yet.
Also

  • convert FastTimerFilter to a global module
  • migrate the FTS to the C++11 std::chono interface for timers

fwyzard and others added 8 commits December 4, 2013 01:33
@fwyzard
drop deprecated parameter enableDQMbyLumi
f44cacc
@fwyzard
add a data member and public accessor for the path "exclusive" time
429d4e7
@fwyzard
fill the DQM plots from internal buffers instead of on the fly
ed79512
@fwyzard
fix comments
a15ae28
@fwyzard
use C++11 type aliases instead of public inheritance
62c7813
@fwyzard
migrate FastTimrService to the threadsafe signales, and reorganise th…
43949da 
…e plots

Cache the first/last path and endpath names by string instead of by
pointer; this makes the comparison slower, but we should migrate to
pathIDs anyway.
In the long term it's not clear whether it makes sense to keep track
of the "first" and "last" paths in a multithreaded environment.
@fwyzard
convert FastTimerFilter to a global EDFilter, and adapt to the thread…
5874f4e 
…safe FastTimerService
@fwyzard
add a FastTimer based on std::chrono::high_resolution_clock
0dbbb0c
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2013

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_7_0_X.

FastTimerService - multithreading fixes part1

It involves the following packages:

HLTrigger/Timer

@Martin-Grunewald, @perrotta, @cmsbuild, @nclopezo, @fwyzard can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@fwyzard
Copy link
Contributor Author

fwyzard commented Dec 6, 2013

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2013

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2013

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1703/1619/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2013

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Dec 7, 2013
@nclopezo
Merge pull request #1703 from fwyzard/FastTimerService_part1
929593c 
FastTimerService - multithreading fixes part1
@nclopezo nclopezo merged commit 929593c into cms-sw:CMSSW_7_0_X Dec 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fully-signed hlt-approved tests-approved
Projects
None yet
Milestone
CMSSW_7_0_0_pre10
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fwyzard @cmsbuild @nclopezo