Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PUPPI lowPUCorr config 90X #17067

Merged
merged 1 commit into from Dec 30, 2016

Conversation

ahinzmann
Copy link
Contributor

@ahinzmann ahinzmann commented Dec 19, 2016

Re-enable PUPPI lowPUCorr, which was unintentionally disabled in #15562.
With lowPUCorr disabled, we get a 1-5% worsening in jet response, though the impact on jet resolution is minor, as shown on slide 6:
https://indico.cern.ch/event/587258/contributions/2366495/attachments/1368938/2117761/satoshi_updatedAfterTheMeeting.pdf
What is labeled v10 is in the CMSSW_8_0_>=20 and CMSSW_8_1_X and CMSSW_9_0_X releases at the moment.
What is labeled v10 LowPUCorr is in CMSSW_8_0_<20 and in this PR.
For CMSSW_8_0_>=20, we have corrected for this response drop with the jet energy corrections, however, we would like to fix this for CMSSW>=8_1_X releases, even though the effect on resolution is minor.

The impact of this PR on jet and MET response and resolution has been validated.

This PR changes the MINIAOD PUPPI jet+MET collection, no changes to RECO/AOD event content.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ahinzmann for CMSSW_9_0_X.

It involves the following packages:

CommonTools/PileupAlgos

@cmsbuild, @cvuosalo, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@jdolen, @rappoccio, @gkasieczka this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@slava77
Copy link
Contributor

slava77 commented Dec 19, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 19, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17109/console Started: 2016/12/19 15:06

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Dec 29, 2016

Some notable plots:

ttbar PU35
all_sign816-patvsorig-gcc530-pat_ttbarpuwf25202p0c_log10patjets_slimmedjetspuppi__pat_obj_et

all_sign816-patvsorig-gcc530-pat_ttbarpuwf25202p0c_patjets_slimmedjetspuppi__pat_obj_neutralhadronenergyfraction

The excess at NH fraction ~1 looks like fakes and corresponds to a half of the increase in the number of puppi jets. (The DQM plots which are apparently made with a higher jet pt threshold do not have much change in the nh fraction distribution)

ZEE PU35 is somewhat similar in the jets distribution.
MET is roughly unchanged in absolute value, which is good.

Contribution of neutrals is considerably larger in MET (plots are from ttbar PU35, but they look similar in ZEE as well)
wf25202_puppimet_hfhadetfrac
wf25202_puppimet_nhetfrac

Trying to pick a channel with higher neutral component: H->gammagamma
there is a large increase in the photon component
all_sign816-patvsorig-gcc530-pat_h125gg13tevwf1332p0c_patjets_slimmedjetspuppi__pat_obj_photonenergyfraction
which also comes with a reduced MET
all_sign816-patvsorig-gcc530-pat_h125gg13tevwf1332p0c_patmets_slimmedmetspuppi__pat_obj_pt

wf1332_puppijet_phfrac

wf1332_puppimet_vsgen

The effect on jets is still significantly visible at PU35, but it is not really significant for MET where PU components is large.

@slava77
Copy link
Contributor

slava77 commented Dec 29, 2016

@ahinzmann
is this rather large change in the photon component at low PU expected?

HGG no PU
all_sign816-patvsorig-gcc530-pat_h125gg13tevwf1332p0c_log10patjets_slimmedjetspuppi__pat_obj_et

It seems to be moving in the right direction for the signal, but it's unclear if it's accidental and can get even [worse] more significant for backgrounds with similar topologies.

@slava77 slava77 mentioned this pull request Dec 30, 2016
@slava77
Copy link
Contributor

slava77 commented Dec 30, 2016

+1

for #17067 cd3ff49

  • the change in the configuration is as documented
  • jenkins tests pass and comparisons show differences only in puppi-related variables
  • local tests confirm moderate changes in jet response and also some significant improvements in MET in events with photons and low PU.

@davidlange6 davidlange6 merged commit 35336f3 into cms-sw:CMSSW_9_0_X Dec 30, 2016
@ahinzmann
Copy link
Contributor Author

@slava77 : At PU<5 and eta<1.3, a jet response increase of 5-10% is expected (slide 6 https://indico.cern.ch/event/587258/contributions/2366495/attachments/1368938/2117761/satoshi_updatedAfterTheMeeting.pdf). This is expected since, without the low PU correction, PUPPI will assign too large PU-probability to neutral particles even if no PU is present (charged particles are untouched by this change). So a rather large increase in the photon component is indeed expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants