Update of the Phase2 Tracker Digitizer Validation suite #17097
Conversation
…gram + trivial updates of title/binning etc for some other exsting histograms
|
A new Pull Request was created by @suchandradutta (Suchandra Dutta) for CMSSW_9_0_X. It involves the following packages: SimTracker/SiPhase2Digitizer @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
please test |
|
Please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
cmsbuild
added
fully-signed
simulation-approved
and removed
pending-signatures
simulation-pending
labels
| unsigned int rawid = DSViter->id; | ||
| DetId detId(rawid); | ||
| if (DetId(detId).det() != DetId::Detector::Tracker) continue; | ||
| int layer = tTopoHandle_->getITPixelLayerNumber(rawid); |
There was a problem hiding this comment.
@suchandradutta -please get the product itself instead of the Handle and use it in the loops (as done elsewhere in this class)
Also, could you update the title of this PR to reflect which validation suite is being updated.Thanks
…ad of Handle in loops
cmsbuild
added
comparison-pending
pending-signatures
simulation-pending
tests-pending
and removed
tests-approved
labels
|
Pull request #17097 was updated. @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
cmsbuild
added
fully-signed
simulation-approved
and removed
pending-signatures
simulation-pending
labels
|
@suchandradutta , improving title of this PR (as David proposed) will not require new test round. |
suchandradutta
changed the title
|
thanks @suchandradutta for having updated the title - As far as I can see, all comments should have been adressed now |
|
+1 |
The Phase2 Digitizer validation suite is updated to include OOT Pile up monitoring histogram + trivial updates of title/binning etc for some other exsisting histograms
@boudoul @delaere @atricomi @emiglior